Re: [PATCH v16 4/9] clk: realtek: Add support for gate clock
From: Brian Masney
Date: Thu Nov 12 2026 - 12:23:07 EST
> Introduce clk_regmap_gate_ops supporting enable, disable, and is_enabled
> for standard regmap gate clocks. To accommodate hardware designs, the
> enable and disable operations handle a 'write_en' flag, which asserts an
> adjacent write-enable bit (bit_idx + 1) simultaneously when modifying the
> gate bit.
>
> Signed-off-by: Cheng-Yu Lee <cylee12@xxxxxxxxxxx>
> Co-developed-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> ---
> Changes in v16:
> - Remove Brian's reviewed-by tag.
> - Replace 'CLK_HW_INIT' with 'CLK_HW_INIT_HW' and 'CLK_HW_INIT_FW_NAME' macros
> to avoid relying on unstable internal CCF global names.
> - Drop all unused NO_PARENT macro and 'rtk_clk_regmap_gate_ro_ops'.
> ---
> drivers/clk/realtek/Makefile | 1 +
> drivers/clk/realtek/clk-regmap-gate.c | 59 +++++++++++++++++++++++++++
> drivers/clk/realtek/clk-regmap-gate.h | 54 ++++++++++++++++++++++++
> 3 files changed, 114 insertions(+)
> create mode 100644 drivers/clk/realtek/clk-regmap-gate.c
> create mode 100644 drivers/clk/realtek/clk-regmap-gate.h
>
> diff --git a/drivers/clk/realtek/Makefile b/drivers/clk/realtek/Makefile
> index 6fbe6e07b760..9397d677f52d 100644
> --- a/drivers/clk/realtek/Makefile
> +++ b/drivers/clk/realtek/Makefile
> @@ -2,5 +2,6 @@
> obj-$(CONFIG_RTK_CLK_COMMON) += clk-rtk.o
>
> clk-rtk-y += clk-rtk-common.o
> +clk-rtk-y += clk-regmap-gate.o
> clk-rtk-y += clk-regmap-pll.o
> clk-rtk-y += freq_table.o
> diff --git a/drivers/clk/realtek/clk-regmap-gate.c b/drivers/clk/realtek/clk-regmap-gate.c
> new file mode 100644
> index 000000000000..12539e11647c
> --- /dev/null
> +++ b/drivers/clk/realtek/clk-regmap-gate.c
> @@ -0,0 +1,59 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/*
> + * Copyright (C) 2017-2026 Realtek Semiconductor Corporation
> + * Author: Cheng-Yu Lee <cylee12@xxxxxxxxxxx>
> + */
> +
> +#include <linux/bits.h>
> +#include <linux/clk-provider.h>
> +#include <linux/export.h>
> +#include <linux/regmap.h>
> +#include "clk-regmap-gate.h"
> +
> +static int rtk_clk_regmap_gate_update(struct clk_hw *hw, bool enable)
> +{
> + struct rtk_clk_regmap_gate *clkg = to_rtk_clk_regmap_gate(hw);
> + unsigned int mask = BIT(clkg->bit_idx);
> + unsigned int val = enable ? mask : 0;
> +
> + /*
> + * Hardware specific design: to modify the gate bit, the adjacent
> + * write-enable bit (bit_idx + 1) must be asserted simultaneously.
> + */
> + if (clkg->write_en) {
> + mask |= BIT(clkg->bit_idx + 1);
> + val |= BIT(clkg->bit_idx + 1);
> + }
> +
> + return regmap_update_bits(clkg->clkr.regmap, clkg->gate_ofs, mask, val);
> +}
> +
> +static int rtk_clk_regmap_gate_enable(struct clk_hw *hw)
> +{
> + return rtk_clk_regmap_gate_update(hw, true);
> +}
> +
> +static void rtk_clk_regmap_gate_disable(struct clk_hw *hw)
> +{
> + rtk_clk_regmap_gate_update(hw, false);
> +}
> +
> +static int rtk_clk_regmap_gate_is_enabled(struct clk_hw *hw)
> +{
> + struct rtk_clk_regmap_gate *clkg = to_rtk_clk_regmap_gate(hw);
> + int ret;
> + u32 val;
> +
> + ret = regmap_read(clkg->clkr.regmap, clkg->gate_ofs, &val);
> + if (ret < 0)
> + return ret;
This becomes a bool in clk_core_is_enabled(). Either return 0 or 1.
Brian
--
Brian Masney <masneyb@xxxxxxxxxx>