Re: [PATCH v4 1/2] block: suspend bio based disks around queue limits updates

[kernel test robot]

Hi Jack,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 6628e7d4c6b25c8d18f1345e3a20d21829aae7e4]

url:    https://github.com/intel-lab-lkp/linux/commits/Jack-Wang/block-suspend-bio-based-disks-around-queue-limits-updates/20261112-144659
base:   6628e7d4c6b25c8d18f1345e3a20d21829aae7e4
patch link:    https://lore.kernel.org/r/20261112134700.372702-2-jinpu.wang%40cloud.ionos.com
patch subject: [PATCH v4 1/2] block: suspend bio based disks around queue limits updates
config: arm-randconfig-1002-20261112 (https://download.01.org/0day-ci/archive/20261113/202611130354.oOiDWpa1-lkp@xxxxxxxxx/config)
compiler: clang version 24.0.0git (https://github.com/llvm/llvm-project 1b1fed44d3dcca649a9877915d57c3357a98124e)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261113/202611130354.oOiDWpa1-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611130354.oOiDWpa1-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   In file included from block/blk-map.c:12:
>> block/blk.h:680:10: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
     680 |                 return queue_limits_commit_update(disk->queue, lim);
         |                        ^
   block/blk.h:681:9: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
     681 |         return queue_limits_commit_update_frozen(disk->queue, lim);
         |                ^
   2 warnings generated.
--
   In file included from block/blk-sysfs.c:14:
>> block/blk.h:680:10: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
     680 |                 return queue_limits_commit_update(disk->queue, lim);
         |                        ^
   block/blk.h:681:9: warning: releasing mutex 'disk->queue->limits_lock' that was not held [-Wthread-safety-analysis]
     681 |         return queue_limits_commit_update_frozen(disk->queue, lim);
         |                ^
>> block/blk-sysfs.c:909:3: warning: mutex '(kobj - #undefined)->queue->limits_lock' is not held on every path through here [-Wthread-safety-analysis]
     909 |                 blk_disk_resume(disk);
         |                 ^
   block/blk-sysfs.c:897:9: note: mutex acquired here
     897 |                 lim = queue_limits_start_update(q);
         |                       ^
   3 warnings generated.


vim +680 block/blk.h

   675	
   676	static inline int blk_disk_commit_limits(struct gendisk *disk,
   677						 struct queue_limits *lim)
   678	{
   679		if (disk->fops->suspend)
 > 680			return queue_limits_commit_update(disk->queue, lim);
   681		return queue_limits_commit_update_frozen(disk->queue, lim);
   682	}
   683	

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki