Re: [PATCH v5 1/4] dt-bindings: PCI: qcom: document the Shikra PCIe controller

From: Rob Herring

Date: Thu Nov 12 2026 - 20:20:14 EST


On Thu, Nov 12, 2026 at 04:33:52PM +0800, Linghui Wu wrote:
> From: Sushrut Shree Trivedi <sushrut.trivedi@xxxxxxxxxxxxxxxx>
>
> Add a dedicated schema for the PCIe controller found on Shikra.
>
> Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@xxxxxxxxxxxxxxxx>
> ---
> .../devicetree/bindings/arm/qcom-soc.yaml | 1 +
> .../bindings/pci/qcom,pcie-shikra.yaml | 192 ++++++++++++++++++
> 2 files changed, 193 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/pci/qcom,pcie-shikra.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom-soc.yaml b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> index 179aadc86a9f..72e0f1a824c6 100644
> --- a/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom-soc.yaml
> @@ -43,6 +43,7 @@ properties:
> - pattern: "^qcom,sar[0-9]+[a-z]?-.*$"
> - pattern: "^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$"
> - pattern: "^qcom,(eliza|kaanapali|kuno|glymur|hawi|mahua|maili|milos|nord|shikra)-.+$"
> + - const: qcom,pcie-shikra

Pretty sure we don't want this. Surely this was pointed out before v5.

>
> # Legacy namings - variations of existing patterns/compatibles are OK,
> # but do not add completely new entries to these: