Re: [PATCH net v7 3/4] can: j1939: drop the message when the reassembled skb is gone

From: Chaosheng Qu

Date: Fri Nov 13 2026 - 00:05:22 EST


Hi,

Both accepted.

Dropping the message silently is the weak part. session->err stays 0, so
j1939_session_destroy() queues nothing, and the only trace is a netdev_dbg()
that is off by default. For an RTS/CTS receive session this runs when the
receiver's own EOMA comes back, after the originator has already been told
the message was delivered, so the two sides end up disagreeing with nothing
in the log. The next version uses WARN_ON_ONCE(!se_skb) and sets
session->err = -EBADMSG before dropping.

The comment in j1939_xtp_rx_dpo_one() does go stale here, but it is 2/4's
comment and gets rewritten there, in the same respin that changes the abort
code.

Thanks,
Chaosheng