Re: [PATCH net v7 3/4] can: j1939: drop the message when the reassembled skb is gone

From: Oleksij Rempel

Date: Fri Nov 13 2026 - 04:01:44 EST


On Fri, Nov 13, 2026 at 11:11:13AM +0800, Chaosheng Qu wrote:
> Hi,
>
> Both accepted.
>
> Dropping the message silently is the weak part. session->err stays 0, so
> j1939_session_destroy() queues nothing, and the only trace is a netdev_dbg()
> that is off by default. For an RTS/CTS receive session this runs when the
> receiver's own EOMA comes back, after the originator has already been told
> the message was delivered, so the two sides end up disagreeing with nothing
> in the log. The next version uses WARN_ON_ONCE(!se_skb) and sets
> session->err = -EBADMSG before dropping.

Hm... will a stack trace provide an additional value in this case? If
not, please use netdev_err_once()



--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |