Re: [PATCH 3/7] drm/amdgpu: Include <asm/cpu_device_id.h> unconditionally
From: Logan Gunthorpe
Date: Fri Nov 13 2026 - 01:33:43 EST
On 2026-11-11 5:48 p.m., Pavel Popov wrote:
> <asm/cpu_device_id.h> now has a generic version, so the #ifdef
> CONFIG_X86 around the include is no longer needed.
>
> <asm/intel-family.h> is included by <asm/cpu_device_id.h>.
>
> Signed-off-by: Pavel Popov <pavel.e.popov@xxxxxxxxx>
> ---
> Depends on <asm-generic/cpu_device_id.h> from [1]; please apply after
> it is in mainline.
>
> [1] https://lore.kernel.org/r/20261111234439.4098-1-pavel.e.popov@xxxxxxxxx
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 19a566187df..fc4e7273630 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -88,10 +88,7 @@
>
> #include <drm/drm_drv.h>
>
> -#if IS_ENABLED(CONFIG_X86)
> -#include <asm/intel-family.h>
> #include <asm/cpu_device_id.h>
> -#endif
>
I don't see the corresponding addition of adding the cpu_device_id.h.
The commit message doesn't mention that. Am I missing something here?
Logan