RE: [PATCH 3/7] drm/amdgpu: Include <asm/cpu_device_id.h> unconditionally
From: Popov, Pavel E
Date: Fri Nov 13 2026 - 15:14:23 EST
> I don't see the corresponding addition of adding the cpu_device_id.h.
> The commit message doesn't mention that. Am I missing something here?
The #include <asm/cpu_device_id.h> line is unchanged; only the #if/#endif
and the redundant <asm/intel-family.h> include are removed.
Thanks,
Pavel
> -----Original Message-----
> From: Logan Gunthorpe <logang@xxxxxxxxxxxx>
> Sent: Thursday, November 12, 2026 9:18 PM
> To: Popov, Pavel E <pavel.e.popov@xxxxxxxxx>; Rafael J. Wysocki
> <rafael@xxxxxxxxxx>; Viresh Kumar <viresh.kumar@xxxxxxxxxx>; Jani Nikula
> <jani.nikula@xxxxxxxxxxxxxxx>; Joonas Lahtinen
> <joonas.lahtinen@xxxxxxxxxxxxxxx>; Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>;
> Tvrtko Ursulin <tursulin@xxxxxxxxxxx>; Alex Deucher
> <alexander.deucher@xxxxxxx>; Christian König
> <christian.koenig@xxxxxxx>; Hans de Goede <hansg@xxxxxxxxxx>; Ilpo
> Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>; Peter Huewe
> <peterhuewe@xxxxxx>; Jarkko Sakkinen <jarkko@xxxxxxxxxx>; Tom Lendacky
> <thomas.lendacky@xxxxxxx>; Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> Cc: Leon Romanovsky <leon@xxxxxxxxxx>; Bjorn Helgaas
> <bhelgaas@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Len Brown
> <lenb@xxxxxxxxxx>; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>; Jason
> Gunthorpe <jgg@xxxxxxxx>; David Airlie <airlied@xxxxxxxxx>; Simona Vetter
> <simona@xxxxxxxx>; David S . Miller <davem@xxxxxxxxxxxxx>;
> x86@xxxxxxxxxx; linux-acpi@xxxxxxxxxxxxxxx; linux-pm@xxxxxxxxxxxxxxx; intel-
> gfx@xxxxxxxxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx; dri-
> devel@xxxxxxxxxxxxxxxxxxxxx; platform-driver-x86@xxxxxxxxxxxxxxx; linux-
> integrity@xxxxxxxxxxxxxxx; linux-crypto@xxxxxxxxxxxxxxx; linux-
> arch@xxxxxxxxxxxxxxx; linux-pci@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 3/7] drm/amdgpu: Include <asm/cpu_device_id.h>
> unconditionally
>
>
>
> On 2026-11-11 5:48 p.m., Pavel Popov wrote:
> > <asm/cpu_device_id.h> now has a generic version, so the #ifdef
> > CONFIG_X86 around the include is no longer needed.
> >
> > <asm/intel-family.h> is included by <asm/cpu_device_id.h>.
> >
> > Signed-off-by: Pavel Popov <pavel.e.popov@xxxxxxxxx>
> > ---
> > Depends on <asm-generic/cpu_device_id.h> from [1]; please apply after
> > it is in mainline.
> >
> > [1]
> > https://lore.kernel.org/r/20261111234439.4098-1-
> pavel.e.popov@xxxxxxxx
> > m
> >
> > drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 ---
> > 1 file changed, 3 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > index 19a566187df..fc4e7273630 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> > @@ -88,10 +88,7 @@
> >
> > #include <drm/drm_drv.h>
> >
> > -#if IS_ENABLED(CONFIG_X86)
> > -#include <asm/intel-family.h>
> > #include <asm/cpu_device_id.h>
> > -#endif
> >
> I don't see the corresponding addition of adding the cpu_device_id.h.
> The commit message doesn't mention that. Am I missing something here?
>
> Logan