Re: [PATCH net-next v1 01/11] net: Get skb fragment addresses through netmem
From: Björn Töpel
Date: Fri Nov 13 2026 - 05:57:15 EST
Mina Almasry <almasrymina@xxxxxxxxxx> writes:
> On Tue, Nov 10, 2026 at 2:21 AM Björn Töpel <bjorn@xxxxxxxxxx> wrote:
>>
>> skb_frag_address() goes through struct page, so a net_iov never has an
>> address. Only unreadable memory should lack one: XDP and BPF read
>> fragments through this helper, and AF_XDP UMEM will back readable
>> net_iovs. netmem_address() also returns NULL, not a bogus pointer, for
>> an unmapped highmem page.
>>
>> Generic code needs the size of a net_iov to find its address, so keep
>> it in struct net_iov_area instead of the devmem binding.
>>
>> Suggested-by: Mina Almasry <almasrymina@xxxxxxxxxx>
>> Suggested-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>
>> Signed-off-by: Björn Töpel <bjorn@xxxxxxxxxx>
>
> Are the changes for niov_shift some kind of rebase error? I don't see
> how they're related. Otherwise changes LGTM.
Not a rebase error, but it's early. Nothing here reads it.
The generic code that needs it is net_iov_address() in patch 4; in this
patch netmem_address() still returns NULL for every net_iov. I'll move
it to patch 4.
Björn