Re: [PATCH] staging: octeon: fix asymmetric output buffer pool accounting

From: Oscar Alejandro Sánchez Lucero

Date: Fri Nov 13 2026 - 05:57:28 EST


On Fri, Nov 13, 2026 at 09:18:47AM +0000, Priyanshu Singh wrote:
> In cvm_oct_configure_common_hw(), when CVMX_FPA_OUTPUT_BUFFER_POOL differs
> from CVMX_FPA_PACKET_POOL, 1024 output buffers are allocated and added to
> the hardware Free Pool Allocator (FPA) pool. However, in cvm_oct_probe()
> (err_tx:) and in cvm_oct_remove(),cvm_oct_mem_empty_fpa() is called with
> 128 instead of 1024 as the expected buffer count.

Hi Priyanshu,

A couple of quick comments:

Was this found via static analysis or code inspection? Since this changes
runtime buffer accounting rather than just coding style, it would be helpful
to mention how it was verified (e.g., compile-tested only) in the commit
message. Also, there is a missing space after the comma in
cvm_oct_remove(),cvm_oct_mem_empty_fpa().

Best regards,
Alejandro Lucero