Re: [PATCH v2 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord

From: Krzysztof Kozlowski

Date: Fri Nov 13 2026 - 09:34:59 EST


On 13/11/2026 11:45, Bartosz Golaszewski wrote:
> On Fri, Nov 13, 2026 at 11:07:38AM +0100, Krzysztof Kozlowski wrote:
>>> @@ -229,6 +231,7 @@ allOf:
>>> compatible:
>>> contains:
>>> enum:
>>> + - qcom,nord-qmp-usb3-dp-phy
>>
>> I don't understand why it is added to two blocks constraining clocks.
>> Does it even pass checks?
>>
>
> Yes, it passes dtbs_check in my WiP branch for USB nodes that will be
> sent as v4 and takes the binding changes into account.
>
> First we add the "qcom,nord-qmp-usb3-dp-phy" to the if block that sets
> minItems to 5. Then we exclude that compatible in the block that does an
> if not and sets minItems: 4 for all non-matching compatibles. This is in
> line with what's being done for existing "qcom,sc7180-qmp-usb3-dp-phy"
> and "qcom,sdm845-qmp-usb3-dp-phy" compatibles.

Oh my... what's with this binding :/

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>

Best regards,
Krzysztof