Re: [PATCH v2 1/3] dt-bindings: phy: qcom,sc8280xp-qmp-usb43dp-phy: Add the cfg_ahb clock for Nord

From: Bartosz Golaszewski

Date: Fri Nov 13 2026 - 13:54:16 EST


On Fri, Nov 13, 2026 at 11:07:38AM +0100, Krzysztof Kozlowski wrote:
> On Thu, Nov 12, 2026 at 04:36:38PM +0100, Bartosz Golaszewski wrote:
> > .../devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> > index 13e64fe510b8f..8d09e6937fef0 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb43dp-phy.yaml
> > @@ -209,11 +209,13 @@ allOf:
> > compatible:
> > contains:
> > enum:
> > + - qcom,nord-qmp-usb3-dp-phy
> > - qcom,sc7180-qmp-usb3-dp-phy
> > - qcom,sdm845-qmp-usb3-dp-phy
> > then:
> > properties:
> > clocks:
> > + minItems: 5
> > maxItems: 5
> > clock-names:
> > items:
> > @@ -229,6 +231,7 @@ allOf:
> > compatible:
> > contains:
> > enum:
> > + - qcom,nord-qmp-usb3-dp-phy
>
> I don't understand why it is added to two blocks constraining clocks.
> Does it even pass checks?
>

Yes, it passes dtbs_check in my WiP branch for USB nodes that will be
sent as v4 and takes the binding changes into account.

First we add the "qcom,nord-qmp-usb3-dp-phy" to the if block that sets
minItems to 5. Then we exclude that compatible in the block that does an
if not and sets minItems: 4 for all non-matching compatibles. This is in
line with what's being done for existing "qcom,sc7180-qmp-usb3-dp-phy"
and "qcom,sdm845-qmp-usb3-dp-phy" compatibles.

Bart