Re: [PATCH net-next 1/3] dt-bindings: net: dptel,dap8211r: add led nodes

From: Conor Dooley

Date: Fri Nov 13 2026 - 12:43:36 EST


On Fri, Nov 13, 2026 at 02:05:43PM +0300, Artem Shimko wrote:
> Document the optional "leds" node supported by the dap8211r phy.
>
> The phy exposes three configurable led outputs, each of which can be
> assigned a color, a function and a default trigger.
>
> Signed-off-by: Artem Shimko <a.shimko.dev@xxxxxxxxx>
> ---
> .../bindings/net/dptel,dap8211r.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml b/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
> index 4cd0f9730d95..43425fc8e96e 100644
> --- a/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
> +++ b/Documentation/devicetree/bindings/net/dptel,dap8211r.yaml
> @@ -20,6 +20,7 @@ description: |
> - IEEE 802.3az-2010 Energy Efficient Ethernet
> - IEEE 1588 SyncE support
> - Internal packet generator and checker for link diagnostics
> + - Three configurable LEDs (link, speed, duplex, TX/RX activity)
>
> allOf:
> - $ref: ethernet-phy.yaml#
> @@ -28,6 +29,22 @@ properties:
> compatible:
> const: ethernet-phy-id0008.011b
>
> + leds:
> + type: object
> + description:
> + Optional node describing the three configurable LEDs of the PHY.
> + Each LED can be assigned a color, function and default trigger
> + (e.g. "netdev" for link/activity indication).

Please add some blank lines here,

> + patternProperties:
> + '^led@[0-2]$':
> + type: object

here,

> + properties:
> + reg:
> + maxItems: 1

here,

> + required:
> + - reg

and here.

> + additionalProperties: true

This whole leds node needs to go down below tx-internal-delay-ps, child
nodes are typically sorted after regular properties.

pw-bot: changes-requested

Thanks,
Conor.

> +
> reg:
> maxItems: 1
>
> @@ -49,6 +66,8 @@ unevaluatedProperties: false
>
> examples:
> - |
> + #include <dt-bindings/leds/common.h>
> +
> mdio {
> #address-cells = <1>;
> #size-cells = <0>;
> @@ -58,5 +77,24 @@ examples:
> reg = <1>;
> rx-internal-delay-ps = <1950>;
> tx-internal-delay-ps = <1950>;
> +
> + leds {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + color = <LED_COLOR_ID_GREEN>;
> + function = LED_FUNCTION_LAN;
> + linux,default-trigger = "netdev";
> + };
> +
> + led@1 {
> + reg = <1>;
> + color = <LED_COLOR_ID_AMBER>;
> + function = LED_FUNCTION_LAN;
> + linux,default-trigger = "netdev";
> + };
> + };
> };
> };
> --
> 2.43.0
>

Attachment: signature.asc
Description: PGP signature