Re: [PATCH net-next 1/3] dt-bindings: net: dptel,dap8211r: add led nodes

[Artem Shimko]

Hi Conor,

On Fri, Nov 13, 2026 at 8:17 PM Conor Dooley <conor@xxxxxxxxxx> wrote:

> > +  leds:
> > +    type: object
> > +    description:
> > +      Optional node describing the three configurable LEDs of the PHY.
> > +      Each LED can be assigned a color, function and default trigger
> > +      (e.g. "netdev" for link/activity indication).
>
> Please add some blank lines here,
>
> > +    patternProperties:
> > +      '^led@[0-2]$':
> > +        type: object
>
> here,
>
> > +        properties:
> > +          reg:
> > +            maxItems: 1
>
> here,
>
> > +        required:
> > +          - reg
>
> and here.
>
> > +        additionalProperties: true
>
> This whole leds node needs to go down below tx-internal-delay-ps, child
> nodes are typically sorted after regular properties.
>
> pw-bot: changes-requested

Thank you for your review, i'll all of the above.

Best regards,
artem