[PATCH 3/4] hwmon: (adt7475) Add thermal zone sensor support

From: Davíð Steinn Geirsson

Date: Fri Nov 13 2026 - 20:05:23 EST


Register the temperature channels as thermal zone sensors. Sensor id N
is temperature channel N, i.e. temp(N+1). Document this in adt7475.rst.

The hwmon core reads a sensor's temperature while registering the
thermal zone, from within hwmon_device_register_with_info(). Read the
chip limits before registering, so that the temperature encoding
(CONFIG5 two's complement bit) is known for that first read.

With CONFIG_THERMAL_OF, devices that have a devicetree node, or sit
below one (the hwmon core uses the nearest ancestor's node), see two
changes:
- Each temperature channel that no thermal zone uses logs
"tempN_input not attached to any thermal zone" once at probe.
- When a thermal zone uses a channel, the hwmon core sets that
channel's min and max limit registers to the zone's current trip
window, as it does for other drivers registering thermal sensors.

Signed-off-by: Davíð Steinn Geirsson <david@xxxxxx>
---
This patch was written with Claude Code, using the models Claude
Opus 5.5 and Claude Fable 5.2. They wrote the code and the initial
commit message draft, which I cleaned up. I directed the design,
reviewed the result, compared against the datasheet as far as I
could, and ran tests including on actual hardware.

Documentation/hwmon/adt7475.rst | 3 +++
drivers/hwmon/adt7475.c | 17 ++++++++++++-----
2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/Documentation/hwmon/adt7475.rst b/Documentation/hwmon/adt7475.rst
index f90f769d82d6..b5976e3ff3d4 100644
--- a/Documentation/hwmon/adt7475.rst
+++ b/Documentation/hwmon/adt7475.rst
@@ -118,6 +118,9 @@ with a resolution of 0.25 degree Celsius. Temperature readings can be
configured either for two's complement format or "Offset 64" format,
wherein 64 is subtracted from the raw value to get the temperature value.

+With ``#thermal-sensor-cells = <1>`` in the device node, thermal sensor id N
+is temperature channel N, reported as temp(N+1).
+
The datasheet is very detailed and describes a procedure for determining
an optimal configuration for the automatic PWM control.

diff --git a/drivers/hwmon/adt7475.c b/drivers/hwmon/adt7475.c
index d5bdb8011e6d..73c19c10bb34 100644
--- a/drivers/hwmon/adt7475.c
+++ b/drivers/hwmon/adt7475.c
@@ -1243,6 +1243,9 @@ static const struct hwmon_ops adt7475_hwmon_ops = {
HWMON_PWM_FREQ | HWMON_PWM_AUTO_CHANNELS_TEMP)

static const struct hwmon_channel_info * const adt7475_info[] = {
+ /* The hwmon core only looks for HWMON_C_REGISTER_TZ in info[0] */
+ HWMON_CHANNEL_INFO(chip,
+ HWMON_C_REGISTER_TZ),
HWMON_CHANNEL_INFO(in,
ADT7475_IN_CONFIG, /* in0: +2.5V */
ADT7475_IN_CONFIG, /* in1: Vccp */
@@ -1928,6 +1931,15 @@ static int adt7475_probe(struct i2c_client *client)
break;
}

+ /*
+ * Read the limits and settings once, before registering: the hwmon
+ * core reads the thermal sensors while registering, and that needs
+ * the temperature encoding from CONFIG5.
+ */
+ ret = adt7475_update_limits(client);
+ if (ret)
+ return ret;
+
data->groups[group_num++] = &adt7475_attr_group;

/* Features that can be disabled individually */
@@ -1966,11 +1978,6 @@ static int adt7475_probe(struct i2c_client *client)
(data->bypass_attn & (1 << 3)) ? " in3" : "",
(data->bypass_attn & (1 << 4)) ? " in4" : "");

- /* Limits and settings, should never change update more than once */
- ret = adt7475_update_limits(client);
- if (ret)
- return ret;
-
return 0;
}

--
2.56.0