Re: [PATCH 0/4] hwmon: (adt7475) Add thermal sensor and PWM provider support

From: Guenter Roeck

Date: Sat Nov 14 2026 - 10:57:59 EST


On 11/14/26 02:23, Davíð Steinn Geirsson wrote:
On Saturday, November 14th, 2026 at 1:03 AM, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:

On 11/13/26 16:41, Davíð Steinn Geirsson wrote:

This series lets boards use the temperature channels of the ADT7473,
ADT7475, ADT7476 and ADT7490 as thermal zone sensors, and drive their
PWM outputs with a PWM consumer such as pwm-fan. The kernel thermal
framework can then control the fans. It follows the ADT7470 series [1],
merged for v7.3.


I am getting flooded with patches, and I have no time to review them all.

Rule change: Functional changes for any hardware monitoring driver which
does not already implement it will have to include conversion to the
with_info hardware monitoring API.

Thank you for taking the time to review, I appreciate it. I will address the items raised in the patch threads and submit a v2 once I've had time to re-validate on hardware.

On the rule change, I'm not sure if this is meant for me? Patch 2/4 changes the adt7475 driver to the with_info API. I will address the locking issue you flagged in that thread, just wondering if there is a larger change being requested here.


No, you are doing exactly what I want people to do. Sorry, I should
have been more specific.

Thanks,
Guenter