Re: [PATCH 4/4] Docs/mm/damon/design: update for DAMON_FILTER_TYPE_ACTIVE
From: Enze Li
Date: Sat Nov 14 2026 - 00:48:32 EST
On 2026/11/13 22:43, SJ Park wrote:
> On Fri, 13 Nov 2026 17:54:37 +0800 Enze Li <lienze@xxxxxxxxxx> wrote:
>
>> Hi SJ,
>>
>> On 11/13/26 1:17 PM, SJ Park wrote:
>>> Update DAMON design document for the newly added LRU-activeness DAMON
>>> filter type.
>>>
>>> Signed-off-by: SJ Park <sj@xxxxxxxxxx>
>>> ---
>>> Documentation/mm/damon/design.rst | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/Documentation/mm/damon/design.rst b/Documentation/mm/damon/design.rst
>>> index 8440c4954090e..b676be6971589 100644
>>> --- a/Documentation/mm/damon/design.rst
>>> +++ b/Documentation/mm/damon/design.rst
>>> @@ -302,6 +302,7 @@ filter types. Currently below filter types are supported.
>>> - ``pgidle_set``: Matches if the page for the memory is marked as access-idle.
>>> - ``hugepage_size``: Matches if the page for the memory is a part of a hugepage
>>> of a given size range.
>>> +- ``active``: Same to that for DAMOS filters.
>>
>> This reads a bit awkward to me. How about:
>>
>> "Same as that for DAMOS filters."
>>
>> The ``anon`` and ``memcg`` entries above use the same wording, so
>> it would be nice to fix those at the same time.
>>
>> WDYT?
>
> Makes sense to me, thank you for sharing the finding, Enze! I also find more
> "same to" usages in the doc. Would you like to send a patch for fixing those
> at once?
Sure, I'd be happy to. I'll send a follow-up patch fixing all six
"same to" usages in design.rst, on top of mm-new.
Best regards,
Enze
<...>