Re: [PATCH 1/2] alpha/serial: Use generic BASE_BAUD in asm/serial.h
From: Magnus Lindholm
Date: Sat Nov 14 2026 - 04:12:53 EST
Hi Thorsten,
On Thu, Nov 12, 2026 at 9:04 PM Thorsten Blum <blum@xxxxxxxxxx> wrote:
>
> Include asm-generic/serial.h and use the generic BASE_BAUD definition
> instead of redefining it.
>
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>
> ---
> arch/alpha/include/asm/serial.h | 10 +---------
> 1 file changed, 1 insertion(+), 9 deletions(-)
>
> diff --git a/arch/alpha/include/asm/serial.h b/arch/alpha/include/asm/serial.h
> index 91115447319c..205e61ef2975 100644
> --- a/arch/alpha/include/asm/serial.h
> +++ b/arch/alpha/include/asm/serial.h
> @@ -3,15 +3,7 @@
> * include/asm-alpha/serial.h
> */
>
> -
> -/*
> - * This assumes you have a 1.8432 MHz clock for your UART.
> - *
> - * It'd be nice if someone built a serial card with a 24.576 MHz
> - * clock, since the 16550A is capable of handling a top speed of 1.5
> - * megabits/second; but this requires the faster clock.
> - */
> -#define BASE_BAUD ( 1843200 / 16 )
> +#include <asm-generic/serial.h>
>
> /* Standard COM flags (except for COM4, because of the 8514 problem) */
> #ifdef CONFIG_SERIAL_8250_DETECT_IRQ
Nice cleanup, looks right to me. Thanks!
Reviewed-by: Magnus Lindholm <linmag7@xxxxxxxxx>