Re: [PATCH 2/2] alpha/serial: Add include guard to asm/serial.h

From: Magnus Lindholm

Date: Sat Nov 14 2026 - 04:14:36 EST


Hi Thorsten,

On Thu, Nov 12, 2026 at 9:04 PM Thorsten Blum <blum@xxxxxxxxxx> wrote:
>
> Add an include guard and remove the stale comment while at it.
>
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>
> ---
> arch/alpha/include/asm/serial.h | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/alpha/include/asm/serial.h b/arch/alpha/include/asm/serial.h
> index 205e61ef2975..7fa754cab5df 100644
> --- a/arch/alpha/include/asm/serial.h
> +++ b/arch/alpha/include/asm/serial.h
> @@ -1,7 +1,6 @@
> /* SPDX-License-Identifier: GPL-2.0 */
> -/*
> - * include/asm-alpha/serial.h
> - */
> +#ifndef _ASM_ALPHA_SERIAL_H
> +#define _ASM_ALPHA_SERIAL_H
>
> #include <asm-generic/serial.h>
>
> @@ -20,3 +19,5 @@
> { 0, BASE_BAUD, 0x2F8, 3, STD_COM_FLAGS }, /* ttyS1 */ \
> { 0, BASE_BAUD, 0x3E8, 4, STD_COM_FLAGS }, /* ttyS2 */ \
> { 0, BASE_BAUD, 0x2E8, 3, STD_COM4_FLAGS }, /* ttyS3 */
> +
> +#endif /* _ASM_ALPHA_SERIAL_H */

Looks good, Thanks!

Reviewed-by: Magnus Lindholm <linmag7@xxxxxxxxx>