[PATCH] net: hso: fix tx skb leak when the device stops

From: Aibing Chen

Date: Sat Nov 14 2026 - 04:32:07 EST


hso_net_start_xmit() stashes the skb in odev->skb_tx_buf and stops the
queue when hso_get_activity() reports -EAGAIN, which happens when the
USB device is suspended or no longer configured. If the interface is
then brought down, or the device is disconnected, that skb is simply
left behind: hso_net_close() and hso_free_net_device() never release
it, and hso_net_open() clears the pointer, so the skb and its data
buffer are leaked.

Free the pending skb in hso_net_close(), which is also reached from
unregister_netdev() on disconnect.

hso_resume() loses a frame in the same way when the device is still not
ready: it passes skb_tx_buf to hso_net_start_xmit() and then clears the
pointer unconditionally, so a frame stashed again by that call is never
freed. Clear the pointer before the call instead and let
hso_net_start_xmit() stash it again if it has to.

Reported-by: syzbot+bf62ca9997f43d2fa521@xxxxxxxxxxxxxxxxxxxxxxxxx
Link: https://lore.kernel.org/all/6af74e31.fe96acdb.12252b.0009.GAE@xxxxxxxxxx/
Signed-off-by: Aibing Chen <chenaibing@xxxxxxxxxxxxxxxxxxxx>
---
drivers/net/usb/hso.c | 12 ++++++++++--
1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 71caa3764..03956fa8e 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -728,6 +728,13 @@ static int hso_net_close(struct net_device *net)

hso_stop_net_device(odev->parent);

+ /*
+ * A frame stashed by hso_net_start_xmit() will never be transmitted now,
+ * so drop it instead of leaking it.
+ */
+ dev_kfree_skb(odev->skb_tx_buf);
+ odev->skb_tx_buf = NULL;
+
/* done */
return 0;
}
@@ -3055,12 +3062,13 @@ static int hso_resume(struct usb_interface *iface)
/* First transmit any lingering data,
then restart the device. */
if (hso_net->skb_tx_buf) {
+ struct sk_buff *skb = hso_net->skb_tx_buf;
+
dev_dbg(&iface->dev,
"Transmitting"
" lingering data\n");
- hso_net_start_xmit(hso_net->skb_tx_buf,
- hso_net->net);
hso_net->skb_tx_buf = NULL;
+ hso_net_start_xmit(skb, hso_net->net);
}
result = hso_start_net_device(network_table[i]);
if (result)