[PATCH v2] net: hso: fix tx skb leak and a race on the stashed skb
From: Aibing Chen
Date: Sun Nov 15 2026 - 05:17:11 EST
hso_net_start_xmit() stashes the skb in odev->skb_tx_buf and stops the
queue when hso_get_activity() reports -EAGAIN, which happens when the
USB device is suspended or no longer configured. If the interface is
then brought down, or the device is disconnected, that skb is simply
left behind: hso_net_close() and hso_free_net_device() never release
it, and hso_net_open() clears the pointer, so the skb and its data
buffer are leaked.
hso_resume() loses a frame in the same way when the device is still not
ready: it passes skb_tx_buf to hso_net_start_xmit() and then clears the
pointer unconditionally, so a frame stashed again by that call is never
freed.
Free the pending skb in hso_net_close() and take ownership of the
pointer with xchg() in both places, so that only one of the close and
resume paths can obtain it. hso_resume() also drops the frame instead
of transmitting it when the interface has already been stopped.
Reported-by: syzbot+bf62ca9997f43d2fa521@xxxxxxxxxxxxxxxxxxxxxxxxx
Link: https://lore.kernel.org/all/6af74e31.fe96acdb.12252b.0009.GAE@xxxxxxxxxx/
Fixes: 72dc1c096c70 ("HSO: add option hso driver")
Fixes: c213f286f2cf ("[netdrvr] hso: dev_kfree_skb crash fix")
Signed-off-by: Aibing Chen <chenaibing@xxxxxxxxxxxxxxxxxxxx>
---
v2:
- take the stashed skb with xchg() in hso_net_close() and hso_resume(),
so that only one path can free it (race reported by sashiko).
- drop the frame in hso_resume() instead of transmitting it after the
interface was stopped.
- add the two Fixes tags.
drivers/net/usb/hso.c | 22 ++++++++++++++++++----
1 file changed, 18 insertions(+), 4 deletions(-)
diff --git a/drivers/net/usb/hso.c b/drivers/net/usb/hso.c
index 71caa3764..ba59bdefd 100644
--- a/drivers/net/usb/hso.c
+++ b/drivers/net/usb/hso.c
@@ -720,6 +720,7 @@ static int hso_net_open(struct net_device *net)
static int hso_net_close(struct net_device *net)
{
struct hso_net *odev = netdev_priv(net);
+ struct sk_buff *skb;
/* we don't need the queue anymore */
netif_stop_queue(net);
@@ -728,6 +729,14 @@ static int hso_net_close(struct net_device *net)
hso_stop_net_device(odev->parent);
+ /*
+ * Take ownership of a frame stashed by hso_net_start_xmit() and drop it.
+ * hso_resume() takes it the same way, so only one of the two paths frees
+ * it.
+ */
+ skb = xchg(&odev->skb_tx_buf, NULL);
+ dev_kfree_skb(skb);
+
/* done */
return 0;
}
@@ -3032,6 +3041,7 @@ static int hso_resume(struct usb_interface *iface)
{
int i, result = 0;
struct hso_net *hso_net;
+ struct sk_buff *skb;
/* Start all serial ports */
for (i = 0; i < HSO_SERIAL_TTY_MINORS; i++) {
@@ -3054,13 +3064,17 @@ static int hso_resume(struct usb_interface *iface)
if (hso_net->flags & IFF_UP) {
/* First transmit any lingering data,
then restart the device. */
- if (hso_net->skb_tx_buf) {
+ skb = xchg(&hso_net->skb_tx_buf, NULL);
+ if (skb) {
dev_dbg(&iface->dev,
"Transmitting"
" lingering data\n");
- hso_net_start_xmit(hso_net->skb_tx_buf,
- hso_net->net);
- hso_net->skb_tx_buf = NULL;
+ if (test_bit(HSO_NET_RUNNING,
+ &hso_net->flags))
+ hso_net_start_xmit(skb,
+ hso_net->net);
+ else
+ dev_kfree_skb(skb);
}
result = hso_start_net_device(network_table[i]);
if (result)