Re: [RFC PATCH] ALSA: hda/realtek: fix missing chained flag in fixup

From: Sungwoo Kim

Date: Sun Nov 15 2026 - 08:36:12 EST


One more, sorry for the multiple followups: CXT_PINCFG_LENOVO_NOTEBOOK
in conexant.c.


On Sun, Nov 15, 2026 at 8:26 AM Sungwoo Kim <iam@xxxxxxxxxxxx> wrote:
>
> One more, ALC668_FIXUP_ASUS_Nx51_HEADSET_MODE in alc662.c also has the
> same issue (missing .chained=true)
>
> On Sun, Nov 15, 2026 at 8:23 AM Sungwoo Kim <iam@xxxxxxxxxxxx> wrote:
> >
> > The fixup specifies a chain_id but does not set the chained flag,
> > which prevents the chained fixup from being executed.
> >
> > Should chained be set to true here?
> >
> > This was identified through static analysis and has not been tested
> > on actual hardware.
> >
> > Signed-off-by: Sungwoo Kim <iam@xxxxxxxxxxxx>
> > ---
> > sound/hda/codecs/realtek/alc269.c | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> > index 96fa8c2782bb..1be2e609c28d 100644
> > --- a/sound/hda/codecs/realtek/alc269.c
> > +++ b/sound/hda/codecs/realtek/alc269.c
> > @@ -6431,6 +6431,7 @@ static const struct hda_fixup alc269_fixups[] = {
> > { 0x1e, 0x411111f0 },
> > { }
> > },
> > + .chained = true,
> > .chain_id = ALC269_FIXUP_DMIC,
> > },
> > [ALC269_FIXUP_CZC_TMI] = {
> > @@ -6449,6 +6450,7 @@ static const struct hda_fixup alc269_fixups[] = {
> > { 0x20, 0x8000ffff },
> > { }
> > },
> > + .chained = true,
> > .chain_id = ALC269_FIXUP_DMIC,
> > },
> > [ALC269_FIXUP_CZC_L101] = {
> > @@ -6467,6 +6469,7 @@ static const struct hda_fixup alc269_fixups[] = {
> > { 0x1e, 0x411111f0 },
> > { }
> > },
> > + .chained = true,
> > .chain_id = ALC269_FIXUP_DMIC,
> > },
> > [ALC269_FIXUP_LEMOTE_A1802] = {
> > @@ -6485,6 +6488,7 @@ static const struct hda_fixup alc269_fixups[] = {
> > { 0x21, 0x03214020 },
> > { }
> > },
> > + .chained = true,
> > .chain_id = ALC269_FIXUP_DMIC,
> > },
> > [ALC269_FIXUP_LEMOTE_A190X] = {
> > @@ -6497,6 +6501,7 @@ static const struct hda_fixup alc269_fixups[] = {
> > { 0x1b, 0x0201401f }, /* front lineout */
> > { }
> > },
> > + .chained = true,
> > .chain_id = ALC269_FIXUP_DMIC,
> > },
> > [ALC256_FIXUP_INTEL_NUC8_RUGGED] = {
> > --
> > 2.47.3
> >