Re: [PATCH net v3 1/7] net: bcm4908_enet: fix the TX ring wrap
From: Kordian Chmielewski
Date: Sun Nov 15 2026 - 08:49:35 EST
Sashiko's review of this patch [1] attributes one Medium point to it:
start_xmit() still stops the queue with netif_stop_queue() when the
descriptor at write_idx has OWN set, and poll_tx() no longer wakes the
queue unconditionally, so a stale OWN descriptor after ifdown/ifup could
stop the queue for good.
In the case the review describes, the ring is empty: start_xmit()
returns before anything has kicked the DMA, so no TX interrupt comes
and poll_tx() never runs. That stop could not be undone before this
patch either; patch 3's changelog describes it. With stale OWN
descriptors further in the ring and frames in flight, the old
unconditional wake could undo such a stop and the new wake does not,
until patch 3 removes the check and clears the TX descriptors when the
ring is initialised. I left that change in patch 3 so that this one
stays the ring wrap fix.
The other points in that review are older than this series. Patches 3,
6 and 7 fix three of them, and the missing TX interrupt is the question
I asked under v2.
[1] https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113235847.517308-1-kudzo51%40gmail.com