Re: [PATCH v2 5/9] MIPS: Ingenic: Update Ingenic XBurst implementation IDs

From: Olivier Louvignes

Date: Sun Nov 15 2026 - 12:01:43 EST


Hi Nikolaus,

On Fri, Nov 13, 2026 at 01:33:23PM +0100, H. Nikolaus Schaller wrote:
> So the lower 4 bits could indeed encode the MXU revision
> and the upper 4 bits the XBurst revision.
[...]
> IMHO, in that case defining PRID_IMP_XBURST = 0x0000 would be correct.
> Maybe the _REV is misleading and should be _MXU_REV?
>
> But that is quite some speculation.
>
> Any thoughts?

The core manuals define that byte. XBurst1 CPU Core PM, 2.3.1.8
(PRId), bits 15:8:

15:13 Generation: 0 - XBurst1, 1 - XBurst2
12:8 uA, micro architecture version ("please reference to SOC
document")

The XBurst2 CPU Core PM, 3.3.1.7, has the same layout, with uA 0 for
the X2000. Decoded:

- X1600 0x00d00000: XBurst1, uA 0
- X1830 0x00d00100: XBurst1, uA 1 (PRID_IMP_XBURST_REV2 today)
- JZ4780 and X1000 (0x...024f): XBurst1, uA 2 (PRID_IMP_XBURST_REV1)
- X2000 and X2600 0x00132000: XBurst2, uA 0 (PRID_IMP_XBURST2)

So the upper bits are the core generation, as you guessed, but the
lower ones number the micro-architecture rather than the MXU: the core
manual leaves their meaning to the SoC documents, and the X1600 PM only
gives the value. This is the reading Maciej gave on my v1, where he
suggested PRID_IMP_XBURST_REV0 for 0x0000 (REV1 and REV2 being swapped
with respect to their values):
https://lore.kernel.org/all/alpine.DEB.2.21.2610262045440.42255@xxxxxxxxxxxxxxxxx/

I have asked Thomas to drop my cpu-probe patch in favour of this one.

Thanks,
Olivier