[PATCH 05/35] iio: adc: ad4170-4: use default_trigger
From: Jonathan Cameron
Date: Sun Nov 15 2026 - 20:50:13 EST
From: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
Set indio_dev->default_trigger rather than taking a reference to the
trigger in probe(). The IIO core now takes the reference during
iio_device_register(), so it is not leaked if probe() fails after
the trigger is set up before the buffer is registered (which sets
the conditions for automatic release of the reference).
Fixes: 9c1d4f4aef0a ("iio: adc: ad4170-4: Add support for buffered data capture")
Signed-off-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
---
This one is technically a fix for the leak. However I only plan to fix
it as part of the the larger set and not to push for a backport.
---
drivers/iio/adc/ad4170-4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad4170-4.c b/drivers/iio/adc/ad4170-4.c
index f7757b3a931c..a04ab03f3938 100644
--- a/drivers/iio/adc/ad4170-4.c
+++ b/drivers/iio/adc/ad4170-4.c
@@ -2830,7 +2830,7 @@ static int ad4170_trigger_setup(struct iio_dev *indio_dev)
if (ret)
return dev_err_probe(dev, ret, "Failed to register trigger\n");
- indio_dev->trig = iio_trigger_get(st->trig);
+ indio_dev->default_trigger = st->trig;
return 0;
}
--
2.56.1