[PATCH 11/35] iio: temperature: tmp006: use default_trigger

From: Jonathan Cameron

Date: Sun Nov 15 2026 - 20:50:14 EST


From: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>

Set indio_dev->default_trigger rather than taking a reference to the
trigger in probe(). The IIO core now takes the reference during
iio_device_register(), so it is not leaked if probe() fails after
the trigger is set up. That leak can occur in this driver, but more
generally the intent is to avoid fragile ordering constraints.

The copy of the trigger pointer in data->drdy_trig is only used during
probe(), so replace it with a local variable.

Fixes: 91f75ccf9f03 ("iio: temperature: tmp006: add triggered buffer support")
Signed-off-by: Jonathan Cameron <jonathan.cameron@xxxxxxxxxxxxxxxx>
---
This one is a fix, but I'm not planning to push for backport given
the impact is a reference and resulting leak of data in an unlikely
error path only.
---
drivers/iio/temperature/tmp006.c | 22 ++++++++++------------
1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/drivers/iio/temperature/tmp006.c b/drivers/iio/temperature/tmp006.c
index d9f6449ec0d8..51196ea9211d 100644
--- a/drivers/iio/temperature/tmp006.c
+++ b/drivers/iio/temperature/tmp006.c
@@ -45,7 +45,6 @@
struct tmp006_data {
struct i2c_client *client;
u16 config;
- struct iio_trigger *drdy_trig;
};

static int tmp006_read_measurement(struct tmp006_data *data, u8 reg)
@@ -297,6 +296,7 @@ static int tmp006_probe(struct i2c_client *client)
{
struct iio_dev *indio_dev;
struct tmp006_data *data;
+ struct iio_trigger *trig;
int ret;

if (!i2c_check_functionality(client->adapter, I2C_FUNC_SMBUS_WORD_DATA))
@@ -340,25 +340,23 @@ static int tmp006_probe(struct i2c_client *client)
return ret;

if (client->irq > 0) {
- data->drdy_trig = devm_iio_trigger_alloc(&client->dev,
- "%s-dev%d",
- indio_dev->name,
- iio_device_id(indio_dev));
- if (!data->drdy_trig)
+ trig = devm_iio_trigger_alloc(&client->dev, "%s-dev%d",
+ indio_dev->name,
+ iio_device_id(indio_dev));
+ if (!trig)
return -ENOMEM;

- data->drdy_trig->ops = &tmp006_trigger_ops;
- iio_trigger_set_drvdata(data->drdy_trig, indio_dev);
- ret = devm_iio_trigger_register(&client->dev, data->drdy_trig);
+ trig->ops = &tmp006_trigger_ops;
+ iio_trigger_set_drvdata(trig, indio_dev);
+ ret = devm_iio_trigger_register(&client->dev, trig);
if (ret)
return ret;

- indio_dev->trig = iio_trigger_get(data->drdy_trig);
+ indio_dev->default_trigger = trig;

ret = devm_request_irq(&client->dev, client->irq,
iio_trigger_generic_data_rdy_poll,
- IRQF_NO_THREAD, "tmp006_irq",
- data->drdy_trig);
+ IRQF_NO_THREAD, "tmp006_irq", trig);
if (ret < 0)
return ret;
}
--
2.56.1