[PATCH] media: dvb-core: initialize DVR ring buffer before registering the device

From: YuanZhe Liu

Date: Sun Nov 15 2026 - 21:44:17 EST


dvb_dmxdev_init() calls dvb_ringbuffer_init() on dmxdev->dvr_buffer
only after dvb_register_device() has registered the DVR device. The
device node becomes usable as soon as device_create() runs inside
dvb_register_device(), so a reader that opens
/dev/dvb/adapterN/dvr0 right after it appears and blocks in read()
can reach wait_event_interruptible() while dvr_buffer.queue is still
zeroed.

The waiter is then queued on a wait queue whose list head is still
all zero. __add_wait_queue() derives (void *)-24 from
head->next == NULL and faults while reading wq->flags:

BUG: unable to handle page fault for address: ffffffffffffffe8
RIP: 0010:__add_wait_queue include/linux/wait.h:177 [inline]
RIP: 0010:prepare_to_wait_event+0x2ef/0x520 kernel/sched/wait.c:316
Call Trace:
dvb_dmxdev_buffer_read drivers/media/dvb-core/dmxdev.c:76
dvb_dvr_read drivers/media/dvb-core/dmxdev.c:277

Commit bfbc0b5b32a8 ("media: dvb-core: fix wrong reinitialization of
ringbuffer on reopen") replaced the dvb_ringbuffer_init() call in
dvb_dvr_open() with dvb_ringbuffer_reset(), so the open path no
longer initializes the queue and dvb_dmxdev_init() is the only place
doing it. Initialize the ring buffer before the device is registered.

Fixes: bfbc0b5b32a8 ("media: dvb-core: fix wrong reinitialization of ringbuffer on reopen")
Cc: stable@xxxxxxxxxxxxxxx
Co-developed-by: Bin Yu <byu@xxxxxxxxxxxxx>
Signed-off-by: Bin Yu <byu@xxxxxxxxxxxxx>
Co-developed-by: Cheng Wen <wencheng@xxxxxxxxxxxxx>
Signed-off-by: Cheng Wen <wencheng@xxxxxxxxxxxxx>
Signed-off-by: YuanZhe Liu <25031212351@xxxxxxxxxxxxxxxxx>
---
drivers/media/dvb-core/dmxdev.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/media/dvb-core/dmxdev.c b/drivers/media/dvb-core/dmxdev.c
index 6a825d9bae43..8ef31066ec8d 100644
--- a/drivers/media/dvb-core/dmxdev.c
+++ b/drivers/media/dvb-core/dmxdev.c
@@ -1431,6 +1431,12 @@ int dvb_dmxdev_init(struct dmxdev *dmxdev, struct dvb_adapter *dvb_adapter)
DMXDEV_STATE_FREE);
}

+ /*
+ * The DVR device node is usable as soon as dvb_register_device()
+ * creates it, so its ring buffer must be initialized first.
+ */
+ dvb_ringbuffer_init(&dmxdev->dvr_buffer, NULL, 8192);
+
ret = dvb_register_device(dvb_adapter, &dmxdev->dvbdev, &dvbdev_demux, dmxdev,
DVB_DEVICE_DEMUX, dmxdev->filternum);
if (ret < 0)
@@ -1441,8 +1447,6 @@ int dvb_dmxdev_init(struct dmxdev *dmxdev, struct dvb_adapter *dvb_adapter)
if (ret < 0)
goto err_register_dvr_dvbdev;

- dvb_ringbuffer_init(&dmxdev->dvr_buffer, NULL, 8192);
-
return 0;

err_register_dvr_dvbdev:
--
2.34.1