Re: [PATCH net] selftests: drv-net: psp: skip unsupported versions in netkit data test
From: Wei Wang
Date: Sun Nov 15 2026 - 21:44:56 EST
On Sun, Nov 15, 2026 at 5:03 AM Alexey Skidanov via B4 Relay
<devnull+alexeys.xsightlabs.com@xxxxxxxxxx> wrote:
>
> From: Alexey Skidanov <alexeys@xxxxxxxxxxxxxx>
>
> data_basic_send_netkit_psp_assoc() runs for PSP versions 0-3. The
> non-netkit data path already skips versions the device does not
> advertise in psp-versions-cap. The netkit path does not, so those
> cases fail instead of skipping.
>
> Version 0 stays mandatory. Skip an unadvertised version before opening
> the PSP connection.
>
> Fixes: 43cf629700fa ("selftests/net: psp: add dev-assoc data path test")
> Signed-off-by: Alexey Skidanov <alexeys@xxxxxxxxxxxxxx>
> Signed-off-by: Lior Yizchak <liory@xxxxxxxxxxxxxx>
> ---
Reviewed-by: Wei Wang <weiwan@xxxxxxxxxx>
> tools/testing/selftests/drivers/net/psp.py | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/tools/testing/selftests/drivers/net/psp.py b/tools/testing/selftests/drivers/net/psp.py
> index c114d2245135..7c8fb2200b39 100755
> --- a/tools/testing/selftests/drivers/net/psp.py
> +++ b/tools/testing/selftests/drivers/net/psp.py
> @@ -728,6 +728,12 @@ def _data_basic_send_netkit_psp_assoc(cfg, version, ipver):
> """
> _assoc_nk_guest(cfg)
>
> + # Version 0 is required by spec, don't let it skip
> + if version:
> + name = cfg.pspnl.consts["version"].entries_by_val[version].name
> + if name not in cfg.psp_info['psp-versions-cap']:
> + raise KsftSkipEx("PSP version not supported", name)
> +
> # Enter guest namespace (netns) to run PSP test
> with NetNSEnter(cfg.netns.name):
> cfg.pspnl = PSPFamily()
>
> ---
> base-commit: aa40afa831ebfe45e40a23721711059f2ac584d4
> change-id: 20261115-main-0b37fbe5e1d2
>
> Best regards,
> --
> Alexey Skidanov <alexeys@xxxxxxxxxxxxxx>
>
>