Re: [PATCH 3/3] pinctrl: ingenic: Add X2600 pin groups and functions
From: Hunter Laux
Date: Mon Nov 16 2026 - 20:18:00 EST
Hi Nikolaus,
On Fri, Nov 13, 2026 at 09:14:58AM +0100, H. Nikolaus Schaller wrote:
> + INGENIC_PIN_GROUP("uart1-data-c", x2600_uart1_data_c, 1),
> + INGENIC_PIN_GROUP("uart2-data", x2600_uart2_data, 1),
> + INGENIC_PIN_GROUP("uart4-data-b", x2600_uart4_data_b, 2),
> + INGENIC_PIN_GROUP("uart5-data-b", x2600_uart5_data_b, 2),
Per the X2600 PM, shouldn't these be 2, 0, 1 and 1?
> +static int x2600_slcd_ctrl_pins[] = {
> + 0x34, 0x3c, 0x3d, 0x3e, 0x3f,
> +};
PB20 (0x34) has no function 1. Did this come from the X2000 table?
Should 0x34 be dropped?
> + INGENIC_PIN_GROUP("pcm", x2600_pcm, 3),
[...]
> + INGENIC_PIN_GROUP("pwm11", x2600_pwm11, 0),
> + INGENIC_PIN_GROUP("pwm12", x2600_pwm12, 0),
> + INGENIC_PIN_GROUP("pwm13", x2600_pwm13, 0),
> + INGENIC_PIN_GROUP("pwm14", x2600_pwm14, 0),
> + INGENIC_PIN_GROUP("pwm15", x2600_pwm15, 0),
> + INGENIC_PIN_GROUP("pwm-trig-c", x2600_pwm_trig_c, 1),
> + INGENIC_PIN_GROUP("pwm-trig-d", x2600_pwm_trig_d, 1),
[...]
> + INGENIC_PIN_GROUP("wait", x2600_wait, 3),
These groups aren't in any function.
> + 0x000007ff, 0xffffffff, 0x7ffbfff, 0x0000ffff, 0x000ffffe,
[...]
> + 0x000007ff, 0xffffffff, 0x01ffff1, 0x0001e000, 0x000fffff,
Port C is missing a digit?
On port E, 0x80 is pull enable and 0x90 selects up/down (PEPE/PEPS).
Doesn't that make the X2000 pull code wrong there?
Hunter