Re: [PATCH] power: supply: gpio-charger: mark gpio_charger_properties as __maybe_unused

From: Sebastian Reichel

Date: Mon Nov 16 2026 - 20:18:15 EST


Hi,

On Mon, Nov 16, 2026 at 11:51:44AM -0700, Nathan Chancellor wrote:
> On Mon, Nov 16, 2026 at 07:41:17AM -0500, Sasha Levin wrote:
> > Commit fad4655224f60 ("power: supply: gpio-charger: Keep properties per
> > device") keeps gpio_charger_properties[] only to size the per-device array
> > with ARRAY_SIZE(). clang sees that the array itself is never emitted and
> > warns, which fails the build with CONFIG_WERROR:
> >
> > drivers/power/supply/gpio-charger.c:26:35: error: variable 'gpio_charger_properties' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
> >
> > Mark the array __maybe_unused.
> >
> > Fixes: fad4655224f60 ("power: supply: gpio-charger: Keep properties per device")
> > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> > ---
> > fad4655224f60 is the tip of power-supply's for-next.
>
> Since the Fixes has 'Cc: stable', this one should too (unless this is
> just going to be squashed in).
>
> Reviewed-by: Nathan Chancellor <nathan@xxxxxxxxxx>

Thanks, I indeed just squashed this into the original commit. It's
the tip anyways and compile errors are always annoying in git
bisect.

Greetings,

-- Sebastian

>
> > drivers/power/supply/gpio-charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/gpio-charger.c b/drivers/power/supply/gpio-charger.c
> > index c90c824382c62..647f5bde38c7c 100644
> > --- a/drivers/power/supply/gpio-charger.c
> > +++ b/drivers/power/supply/gpio-charger.c
> > @@ -23,7 +23,7 @@ struct gpio_mapping {
> > } __packed;
> >
> > /* This list ensures, that the array is big enough for all optional features. */
> > -static enum power_supply_property gpio_charger_properties[] = {
> > +static enum power_supply_property gpio_charger_properties[] __maybe_unused = {
> > POWER_SUPPLY_PROP_ONLINE,
> > POWER_SUPPLY_PROP_STATUS,
> > POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT_MAX,
> >
> > base-commit: fad4655224f60328cc9bcf4399eda8f6d7a587a6
> > --
> > 2.53.0
> >
>
> --
> Cheers,
> Nathan

Attachment: signature.asc
Description: PGP signature