RE: [PATCH rtw-next 5/6] wifi: rtlwifi: use ieee80211_is_ctl() instead of WLAN_FC_GET_TYPE()
From: Ping-Ke Shih
Date: Mon Nov 16 2026 - 21:44:50 EST
Rishik Yechuri <epicrishik@xxxxxxxxx> wrote:
> Six RX status parsers read the frame type with WLAN_FC_GET_TYPE() from
> wifi.h only to compare it against IEEE80211_FTYPE_CTL.
> ieee80211_is_ctl() from <linux/ieee80211.h> does that test directly on
> the little endian frame control.
>
> Use it at the six sites, drop the type variables that only held the
> result, and remove WLAN_FC_GET_TYPE() together with WLAN_FC_GET_VERS(),
> WLAN_FC_GET_STYPE() and WLAN_FC_MORE_DATA(), which have no users.
Please reword your commit messages.
The subject has pointed out the key point. No need much verbose
messages generated by LLM.