Re: [PATCH v3 1/5] rust: task: add safe schedule_timeout() wrapper
From: Gary Guo
Date: Tue Nov 17 2026 - 07:02:34 EST
On Tue Nov 17, 2026 at 11:56 AM GMT, Danilo Krummrich wrote:
> On Tue Nov 17, 2026 at 12:40 PM CET, Gary Guo wrote:
>> On Tue Nov 17, 2026 at 12:45 AM GMT, FUJITA Tomonori wrote:
>>> On Tue, 17 Nov 2026 01:14:42 +0100
>>> Danilo Krummrich <dakr@xxxxxxxxxx> wrote:
>>>
>>>> +pub fn schedule_timeout(timeout: Delta<Jiffy>) -> Delta<Jiffy> {
>>>> + let timeout = timeout.as_jiffies().max(0);
>>>
>>> In earlier reviews of my patches, Gary asked me to use the function
>>> syntax or clamp() for this instead of the method syntax [1][2]:
>>>
>>> let timeout = isize::max(timeout.as_jiffies(), 0);
>>
>> Yes, please do. I'm okay with either `isize::max` or `cmp::max`.
>
> The examples in [1][2] both seemed to be able to avoid a cast with this, which
> isn't the case for this patch. There also doesn't seem to be any ambiguity in
> the extression used in this patch. So I don't see why changing it would be
> better.
The ambiguity is "the maximum value returned will be 0" and "the minimum value
returned will be 0". The answer is always the latter but I'd avoid the mental
gymnastics.
Best,
Gary