Re: [PATCH iwl-next 04/15] idpf: psp: add psp offload initialization

From: Daniel Zahka

Date: Tue Nov 17 2026 - 12:35:05 EST


On Tue Nov 17, 2026 at 9:55 AM EST, Stan Iliev wrote:
> Add the PSP offload initialization:
> - Introduce VIRTCHNL2_CAP_CRYPTO (bit 26 of the other capabilities)
> and request it in VIRTCHNL2_OP_GET_CAPS if CONFIG_INET_PSP is
> enabled.
> - Add struct idpf_adapter_psp to struct idpf_adapter.
> - Implement idpf_psp_init(), called from idpf_vc_core_init() on each
> core init, including after a hard reset, and idpf_psp_free(), called
> from idpf_remove(). PSP is enabled if VIRTCHNL2_CAP_CRYPTO was
> granted, see idpf_is_psp_ena(). A failure disables PSP instead of
> failing the core init.
> - Add the PSP device ops with idpf_psp_set_config(), and
> idpf_psp_register()/idpf_psp_unregister(). The PSP device is
> registered in a later patch, once all mandatory PSP device ops and the
> datapath are implemented.
> - Build idpf_psp.c only with CONFIG_INET_PSP, with static inline stubs
> in idpf_psp.h otherwise.
>
> Signed-off-by: Stan Iliev <stani@xxxxxxxxxx>
> ---
> +
> +/**
> + * idpf_psp_set_config - Set the PSP device configuration
> + * @psd: PSP device
> + * @conf: new configuration
> + * @extack: netlink extended ack for error reporting
> + *
> + * The configuration is applied by the PSP core.
> + *
> + * Return: 0.
> + */
> +static int idpf_psp_set_config(struct psp_dev *psd, struct psp_dev_config *conf,
> + struct netlink_ext_ack *extack)
> +{
> + return 0;

this is supposed to enable/disable PSP Rx on the device. It should
probably either do something or have a TODO or comment explaining that
the HW doesn't support disabling parsing packets as PSP.