Re: [PATCH 1/9] dt-bindings: net: rockchip-dwmac: Allow iommus

From: netdev-bot+sashiko

Date: Tue Nov 17 2026 - 12:35:21 EST


Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] This patch ("dt-bindings: net: rockchip-dwmac: Allow iommus")
adds `iommus: maxItems: 1` to the top-level `properties:` map of…

--

dt-bindings: net: rockchip-dwmac: Allow iommus

This commit adds an iommus property, limited to one entry, to the
Rockchip DWMAC binding. The commit message says the RK3588 GMACs sit
behind the PHP SMMU.

> diff --git a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> index e8dda1961ab31..2a0cd56fb4fe9 100644
> --- a/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/rockchip-dwmac.yaml
> @@ -87,6 +87,9 @@ properties:
>
> dma-coherent: true
>
> + iommus:
> + maxItems: 1
> +

[Severity: Low]
The commit message only gives a reason for RK3588, but iommus is added to
the top-level properties without any compatible-based condition. Was it
intended to allow iommus on every Rockchip GMAC compatible (px30, rk3128,
rk3228, rk3288, rk3308, rk3328, rk3366, rk3368, rk3399, rk3506, rk3528,
rk3568, rk3576, rv1108, rv1126)?

In the in-tree DTS, the only SMMU a GMAC could reference appears to be
mmu600_php in rk3588-base.dtsi:

arch/arm64/boot/dts/rockchip/rk3588-base.dtsi:
mmu600_php: iommu@fcb00000 {

The same binding already restricts the PHP-specific rockchip,php-grf
property to the SoCs that have it:

- if:
properties:
compatible:
contains:
enum:
- rockchip,rk3576-gmac
- rockchip,rk3588-gmac
then:
required:
- rockchip,php-grf
else:
properties:
rockchip,php-grf: false

As written, a GMAC node for a non-RK3588 SoC that carries an iommus
phandle (for example, one copied from an RK3588 node) would pass
dtbs_check without a warning.

Could iommus be scoped in a similar conditional, with iommus: false for
the compatibles other than rockchip,rk3588-gmac? If allowing it on all
variants is intentional, could the commit message say so?

> clock_in_out:
> description:
> For RGMII, it must be "input", means main clock(125MHz)

--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-mmu600-php-v1-0-231196049a3b%40gmail.com