Re: [PATCH 2/9] dt-bindings: ata: rockchip,dwc-ahci: Allow iommus

From: netdev-bot+sashiko

Date: Tue Nov 17 2026 - 12:35:27 EST


Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] The patch adds `iommus: maxItems: 1` at the top level of
`Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml` (lines…

--

dt-bindings: ata: rockchip,dwc-ahci: Allow iommus

This adds an iommus property, limited to one item, to the Rockchip DWC
AHCI binding. The commit message says the RK3588 SATA controllers sit
behind the PHP SMMU.

> diff --git a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> index b5ecaabfe2e25..e33e8b5591ee5 100644
> --- a/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> +++ b/Documentation/devicetree/bindings/ata/rockchip,dwc-ahci.yaml
> @@ -34,6 +34,9 @@ properties:
> - rockchip,rk3588-dwc-ahci
> - const: snps,dwc-ahci
>
> + iommus:
> + maxItems: 1
> +

[Severity: Low]
Should iommus be limited to rockchip,rk3588-dwc-ahci?

As added, the property is unconditional. That makes it valid for all
three compatibles in the select block: rockchip,rk3568-dwc-ahci,
rockchip,rk3576-dwc-ahci and rockchip,rk3588-dwc-ahci.

The commit message only gives a hardware reason for RK3588:

The RK3588 SATA controllers are behind the PHP SMMU.

The in-tree SoC descriptions match that. mmu600_php: iommu@fcb00000
(arm,smmu-v3) exists only in rk3588-base.dtsi. In rk356x-base.dtsi and
rk3576.dtsi, the only IOMMUs are for media blocks (vdpu, vepu, vicap,
vop, vdec), and none of them sit in front of the SATA nodes.

The binding already has a separate allOf entry for the older SoCs:

- if:
properties:
compatible:
contains:
enum:
- rockchip,rk3568-dwc-ahci
- rockchip,rk3576-dwc-ahci
then:
properties:
clocks:
maxItems: 3

With this patch, dtbs_check would no longer flag an iommus property
added by mistake to an RK3568 or RK3576 SATA node.

One option is to add iommus: false to the rk3568/rk3576 then: branch.
Another is to allow iommus only in the rk3588 branch.

snps,dwc-ahci.yaml, which the commit message cites, does allow iommus
unconditionally. This binding is per-SoC, though, and already has
per-compatible constraints.

> ports-implemented:
> const: 1
>

--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-mmu600-php-v1-0-231196049a3b%40gmail.com