Re: [PATCH 6/9] soc: rockchip: grf: Restore the RK3588 PHP StreamIDs after system suspend
From: netdev-bot+sashiko
Date: Tue Nov 17 2026 - 12:35:32 EST
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The concern: the commit message says that 'The SMMU aborts a
master whose StreamID was lost', but at this commit mmu600_php is…
--
soc: rockchip: grf: Restore the RK3588 PHP StreamIDs after system suspend
This commit keeps the RK3588 PHP GRF StreamID table after init. It also
registers a syscore resume op that rewrites any StreamIDs lost when PD_PHP
is powered off during system suspend. The op is only registered when the
GRF node has a clocks property.
> The PHP GRF is in PD_PHP, which firmware may power off in system
> suspend. The SMMU aborts a master whose StreamID was lost.
[Severity: Low]
Is this description accurate for the tree at this commit?
In arch/arm64/boot/dts/rockchip/rk3588-base.dtsi the mmu600_php node is
still disabled at this point:
mmu600_php: ...
...
status = "disabled";
None of usb3otg2, gmac0/1 or sata0-2 point at it with an iommus property
yet. That means the SMMU abort described above can't happen in-tree with
this patch alone, and rockchip_grf_resume() has no visible effect yet.
Two later patches in the series fix that:
"arm64: dts: rockchip: Attach the masters of the RK3588 PHP SMMU"
adds iommus = <&mmu600_php N> to the six masters.
"arm64: dts: rockchip: Enable the RK3588 PHP SMMU" removes the
status = "disabled" line.
So by the end of the series the restore does take effect.
Could the commit message say that this patch prepares for those later DTS
changes? Or could the patch be moved after them in the series?
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-mmu600-php-v1-0-231196049a3b%40gmail.com