Re: [PATCH net-next v11 03/14] net: ethernet: oa_tc6: Move oa_tc6.c to its own directory
From: netdev-bot+sashiko
Date: Tue Nov 17 2026 - 14:53:04 EST
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] The commit message for "net: ethernet: oa_tc6: Move oa_tc6.c to
its own directory" ends with: "This patch series adds two files, one…
--
net: ethernet: oa_tc6: Move oa_tc6.c to its own directory
This commit moves drivers/net/ethernet/oa_tc6.c into a new
drivers/net/ethernet/oa_tc6/ directory and renames it to oa_tc6_main.c.
The module is still built as oa_tc6.ko. The OA_TC6 Kconfig entry moves
into its own Kconfig file, and the Makefile and MAINTAINERS entries are
updated to match.
> This patch series adds two files, one for hardware
> timestamp related functions and one for PTP related APIs.
[Severity: Low]
This isn't a bug, but should this paragraph be reworded?
This commit doesn't add either of those files. It only renames oa_tc6.c to
oa_tc6/oa_tc6_main.c and adds the new oa_tc6/Kconfig and oa_tc6/Makefile.
The hardware timestamp and PTP files (oa_tc6_tstamp.c and oa_tc6_ptp.c)
come in later patches of the series, such as "net: ethernet: oa_tc6:
Support for hardware timestamp".
Once this commit is in git history, "this patch series" no longer points
to anything. Could this text go in the cover letter instead? Another
option is a forward-looking line, for example "Subsequent patches will add
files for hardware timestamping and PTP support."
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-s2500-mac-phy-support-v11-0-7a186141952c%40onsemi.com