Re: [PATCH net-next v11 05/14] net: ethernet: microchip: lan865x: Depends on PTP_1588_CLOCK_OPTIONAL
From: netdev-bot+sashiko
Date: Tue Nov 17 2026 - 14:53:31 EST
Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.
Low priority / nit picks for your consideration:
- [Low] Rejected as a false positive.
--
net: ethernet: microchip: lan865x: Depends on PTP_1588_CLOCK_OPTIONAL
This patch adds a PTP_1588_CLOCK_OPTIONAL dependency to the LAN865X
Kconfig entry. It prepares for a later patch in the series that makes
OA_TC6 depend on PTP_1588_CLOCK_OPTIONAL. A select of OA_TC6 does not
pick up that dependency, so without this change LAN865X=y with
PTP_1588_CLOCK=m could fail to link on ptp_clock_register().
> diff --git a/drivers/net/ethernet/microchip/lan865x/Kconfig b/drivers/net/ethernet/microchip/lan865x/Kconfig
> index 7f2a4e7e1915f..342172cb8837d 100644
> --- a/drivers/net/ethernet/microchip/lan865x/Kconfig
> +++ b/drivers/net/ethernet/microchip/lan865x/Kconfig
> @@ -8,6 +8,7 @@ if NET_VENDOR_MICROCHIP
> config LAN865X
> tristate "LAN865x support"
> depends on SPI
> + depends on PTP_1588_CLOCK_OPTIONAL
> select OA_TC6
> help
I didn't find any regressions in this patch.
The next patch in the series adds the same dependency to ADIN1140, which
also selects OA_TC6. That happens before "net: ethernet: oa_tc6: Support
for hardware timestamp" adds the dependency to OA_TC6 itself, so no
commit in the series should hit the link failure.
--
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261113-s2500-mac-phy-support-v11-0-7a186141952c%40onsemi.com