Re: [PATCH v4 6/7] pinctrl: ingenic: Handle X2600 Port E Schmitt trigger
From: H. Nikolaus Schaller
Date: Thu Nov 19 2026 - 05:12:24 EST
Hi Paul,
> Am 19.11.2026 um 11:00 schrieb Paul Cercueil <paul@xxxxxxxxxxxxxxx>:
>
> Hi Nikolaus,
>
> Le mercredi 18 novembre 2026 à 18:25 +0100, H. Nikolaus Schaller a écrit :
>> Port E has two Schmitt trigger configuration bits per pin.
>> Select the lower-hysteresis mode when enabling and read both bits
>> to report firmware-initialized settings.
>>
>> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
>> ---
>> drivers/pinctrl/pinctrl-ingenic.c | 9 +++++++++
>> 1 file changed, 9 insertions(+)
>>
>> diff --git a/drivers/pinctrl/pinctrl-ingenic.c b/drivers/pinctrl/pinctrl-
>> ingenic.c
>> index 02ebfecf9563a..876e8e9e00c45 100644
>> --- a/drivers/pinctrl/pinctrl-ingenic.c
>> +++ b/drivers/pinctrl/pinctrl-ingenic.c
>> @@ -69,6 +69,7 @@
>> #define X2000_GPIO_PEPD 0x90
>> #define X2000_GPIO_SR 0xd0
>> #define X2000_GPIO_SMT 0xe0
>> +#define X2600_GPIO_SMT1 0x100
>>
>> #define X2600_GPIO_SHADOW_OFFSET 0x800
>> #define X2600_GPIO_PAGLD (X2600_GPIO_SHADOW_OFFSET +
>> 0xf0)
>> @@ -4697,6 +4698,9 @@ static int ingenic_pinconf_get(struct pinctrl_dev
>> *pctldev,
>> return -EINVAL;
>>
>> arg = !!ingenic_get_pin_config(jzpc, pin, reg);
>> + if (is_soc(jzpc, ID_X2600) && offt == 4)
>> + arg |= !!ingenic_get_pin_config(jzpc, pin,
>> + X2600_GPIO_SMT1);
>
> You mis-align it here, then fix it in patch [7/7] in a somewhat unrelated patch.
Sometimes my tools have this as an unexpected side-effect. Sorry for not recognizing it before.
BR and thanks,
Nikolaus
>
> Honestly, you can keep it on one line - the hard limit is 100 chars per line
> now, and splitting here does not make the code more readable, on the contrary.
>
>> break;
>>
>> case PIN_CONFIG_SLEW_RATE:
>> @@ -4771,6 +4775,11 @@ static void ingenic_set_bias(struct ingenic_pinctrl
>> *jzpc,
>> static void ingenic_set_schmitt_trigger(struct ingenic_pinctrl *jzpc,
>> unsigned int pin, bool enable)
>> {
>> + /* Port E uses two bits; select the lower-hysteresis Schmitt mode. */
>> + if (is_soc(jzpc, ID_X2600) &&
>> + pin / PINS_PER_GPIO_CHIP == 4)
>
> Same here, no need to split.
>
> Cheers,
> -Paul
>
>> + ingenic_config_pin(jzpc, pin, X2600_GPIO_SMT1, false);
>> +
>> if (is_soc_or_above(jzpc, ID_X2000))
>> ingenic_config_pin(jzpc, pin, X2000_GPIO_SMT, enable);
>> else
> _______________________________________________
> https://projects.goldelico.com/p/gta04-kernel/
> Letux-kernel mailing list
> Letux-kernel@xxxxxxxxxxxxxxx
> http://lists.goldelico.com/mailman/listinfo.cgi/letux-kernel