Re: [PATCH v10 05/13] mfd: nct6694: Drop the unused IRQ enable mask

From: Sebastian Andrzej Siewior

Date: Thu Nov 19 2026 - 05:12:43 EST


On 2026-11-18 16:16:16 [+0800], a0282524688@xxxxxxxxx wrote:
> From: Ming Yu <a0282524688@xxxxxxxxx>
>
> The .irq_enable and .irq_disable callbacks only update the irq_enable
> bitmask under irq_lock, which is a spinlock_t. Nothing ever reads that
> bitmask, so the callbacks do not mask anything. They also take irq_lock
> while the IRQ core holds desc->lock, a raw spinlock. On PREEMPT_RT this
> is an invalid wait context.
>
> Remove both callbacks, along with irq_enable and irq_lock, and keep
> IRQCHIP_SKIP_SET_WAKE. Without .irq_disable, the IRQ core falls back to
> lazy disable, and handle_simple_irq() keeps a disabled interrupt pending
> instead of calling its handler. The behaviour is therefore unchanged.
>
> Fixes: 51dad33ede63 ("mfd: Add core driver for Nuvoton NCT6694")
> Signed-off-by: Ming Yu <a0282524688@xxxxxxxxx>

This sort of makes sense. But how does this work? If the interrupt keeps
coming the irq-core will just suppress it?
If that is your whole business why not use dummy_irq_chip?

As far as the change goes,

Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Sebastian