Re: [PATCH 08/15] dt-bindings: clock: versal: add Versal Gen 2 compatible string
From: Krzysztof Kozlowski
Date: Thu Nov 19 2026 - 05:55:21 EST
On 19/11/2026 00:32, Gregory Williams wrote:
> From: Naman Trivedi <naman.trivedimanojbhai@xxxxxxx>
>
> Add compatible string for Versal Gen 2 clock driver and validate
> clock-names for xlnx,versal2-clk compatible.
>
> Signed-off-by: Naman Trivedi <naman.trivedimanojbhai@xxxxxxx>
> Signed-off-by: Senthil Nathan Thangaraj <senthilnathan.thangaraj@xxxxxxx>
Still incomplete DCO. Please read submitting patches to understand what
you must sign.
> ---
> Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> index 1f36ccc4cde1..e06f1ebc192a 100644
> --- a/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> +++ b/Documentation/devicetree/bindings/clock/xlnx,versal-clk.yaml
> @@ -17,10 +17,13 @@ description: |
> properties:
> compatible:
> oneOf:
> - - const: xlnx,versal-clk
> + - enum:
> + - xlnx,versal-clk
> + - xlnx,versal2-clk
> - items:
> - enum:
> - xlnx,versal-net-clk
> + - xlnx,versal2-clk
I don't understand this, it makes no sense. How exactly the same device
is and is not compatible with older one?
Please read DTS101 slides.
> - const: xlnx,versal-clk
>
> "#clock-cells":
Best regards,
Krzysztof