Re: [PATCH v2 0/3] thermal: samsung: acpm-tmu: Add Exynos850 support
From: Tudor Ambarus
Date: Thu Nov 19 2026 - 06:41:14 EST
Hi, Alexey!
Thanks for the series!
On 11/18/26 3:51 PM, Alexey Klimov wrote:
> This series adds support for the Thermal Management Unit found on
> the Samsung Exynos850 SoC to the existing acpm-tmu driver.
Exynos850 almost doubles acpm-tmu.c, and most of the new code is
register-level handling that has nothing in common with GS101.
I'd like to split the driver now, while we add the second SoC,
rather than later. The layout could be:
drivers/thermal/samsung/
acpm-tmu.h internal header: acpm_tmu_priv, acpm_tmu_sensor,
SoC driver data / callbacks
acpm-tmu.c probe, PM, thermal zone ops, threaded IRQ, OF match
table, locking and sensor disable/enable around
threshold updates
acpm-tmu-gs101.c ACPM IPC callbacks, sensor groups, regmap config
acpm-tmu-exynos850.c MMIO init and trimming, threshold and interrupt
registers
obj-$(CONFIG_EXYNOS_ACPM_THERMAL) += exynos-acpm-tmu.o
exynos-acpm-tmu-y += acpm-tmu.o acpm-tmu-gs101.o \
acpm-tmu-exynos850.o
See drivers/thermal/qcom/tsens* for a similar layout.
Also, please note Christian's fix for GS101 threshold 7 [1], you'll likely
need to rebase your set on his v2 as it's a fix and shall come first.
[1] https://lore.kernel.org/all/20261117083442.830549-1-christian.loehle@xxxxxxx/
Cheers,
ta