Re: [PATCH v3 0/9] cpufreq: tegra194: add Tegra264 support
From: Zhongqiu Han
Date: Thu Nov 19 2026 - 06:41:50 EST
On 11/19/2026 7:12 PM, Sumit Gupta wrote:
This series adds cpufreq support for Tegra264, which joins the SoCs
already supported by the tegra194-cpufreq driver.
Tegra264 keeps the existing model, where BPMP provides the NDIV limits.
The driver derives the current frequency from the core clock and
reference counters.
The main differences are:
- Frequency read: through system registers, as on Tegra194, but from
the 64-bit architected AMU counters. The reference counter ticks at
the system counter rate (CNTFRQ).
- Frequency request: through MMIO, as on Tegra234. The driver writes
NDIV to a core_freq_req register in the CCPLEX register space. Each
register controls a clock shared by two single-CPU clusters, so both
CPUs form one cpufreq policy.
The patches fall into four groups:
- Fix (patch 1): read each CPU's MPIDR from a CPU hotplug callback
instead of at probe. A CPU that is offline at probe then also gets
valid cluster and core IDs.
- Preparation (patches 2 to 5): cleanups, mostly of the counter code,
to make room for a 64-bit counter and for an MMIO mapping without
ACTMON counters.
- Improvement (patches 6 and 7): group CPUs by the generic
"performance-domains" property, which cluster-based grouping cannot
express on Tegra264. Device trees without it keep the existing
grouping.
- Tegra264 support (patches 8 and 9): the driver support, followed by
the device tree changes it relies on.
v2[2] -> v3:
- Patch 8: read the AMU counters with interrupts disabled (Zhongqiu).
- Add Reviewed-by from Zhongqiu to patches 1-7 and 9.
For patch 8/9:
Reviewed-by: Zhongqiu Han <zhongqiu.han@xxxxxxxxxxxxxxxx>
v1[1] -> v2:
- Patch 1: drop the cpu argument of get_cpu_cluster_id() (Zhongqiu).
Check for a bad MPIDR in tegra194_get_speed() (Sashiko).
- Patch 7: check the BPMP table in tegra194_get_speed() (Sashiko).
- Patch 8: fail probe if AMU is not available (Zhongqiu).
Sumit Gupta (9):
cpufreq: tegra194: move MPIDR read to CPU hotplug callback
cpufreq: tegra194: remove duplicate counter sampling loops
cpufreq: tegra194: add tegra_counter_delta helper
cpufreq: tegra194: add per-SoC counter mask
cpufreq: tegra194: split MMIO mapping from ACTMON offset
dt-bindings: arm: nvidia: Document the Tegra264 CCPLEX cluster
cpufreq: tegra194: derive frequency domain from device tree
cpufreq: tegra194: Add support for Tegra264
arm64: tegra: Add CCPLEX cluster node for Tegra264
.../tegra/nvidia,tegra-ccplex-cluster.yaml | 27 +-
arch/arm64/boot/dts/nvidia/tegra264.dtsi | 21 +
drivers/cpufreq/Kconfig.arm | 4 +-
drivers/cpufreq/tegra194-cpufreq.c | 456 +++++++++++++-----
4 files changed, 387 insertions(+), 121 deletions(-)
[1] v1: https://lore.kernel.org/lkml/20261104181521.3003578-1-sumitg@xxxxxxxxxx/
[2] v2: https://lore.kernel.org/lkml/20261117154954.625126-1-sumitg@xxxxxxxxxx/
base-commit: e8017d29067fd1310a65c3494ce1a1b492adbac6
--
Thx and BRs,
Zhongqiu Han