[PATCH 2/6] firmware: xilinx: Call va_start after pm feature check
From: Michal Simek
Date: Thu Nov 19 2026 - 08:18:10 EST
There is no reason to start to process va_list before calling pm feature
check which can still fail. Call it at a time when list can be process.
Co-developed-by: Senthil Nathan Thangaraj <senthilnathan.thangaraj@xxxxxxx>
Signed-off-by: Senthil Nathan Thangaraj <senthilnathan.thangaraj@xxxxxxx>
Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
---
drivers/firmware/xilinx/zynqmp.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index 22ee6ccdb02c..a0ec904b1819 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -391,13 +391,13 @@ int zynqmp_pm_invoke_fw_fn(u32 pm_api_id, u32 *ret_payload, u32 num_args, ...)
if (num_args > SMC_ARG_CNT_32)
return -EINVAL;
- va_start(arg_list, num_args);
-
/* Check if feature is supported or not */
ret = zynqmp_pm_feature(pm_api_id);
if (ret < 0)
return ret;
+ va_start(arg_list, num_args);
+
for (i = 0; i < num_args; i++)
args[i] = va_arg(arg_list, u32);
@@ -454,13 +454,13 @@ int zynqmp_pm_invoke_fn(u32 pm_api_id, u32 *ret_payload, u32 num_args, ...)
if (num_args > 14)
return -EINVAL;
- va_start(arg_list, num_args);
-
/* Check if feature is supported or not */
ret = zynqmp_pm_feature(pm_api_id);
if (ret < 0)
return ret;
+ va_start(arg_list, num_args);
+
for (i = 0; i < num_args; i++)
args[i] = va_arg(arg_list, u32);
--
2.43.0