[PATCH 4/6] firmware: xilinx: Call pm sysfs out of dev_groups
From: Michal Simek
Date: Thu Nov 19 2026 - 08:18:20 EST
PM (Power Management) functionality is only one part of firmware interface
that's why move sysfs registration to own function and call it separately
as preparation for spliting functionality based on service type.
Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
---
drivers/firmware/xilinx/zynqmp.c | 23 ++++++++++++++++++++---
1 file changed, 20 insertions(+), 3 deletions(-)
diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index 597393d5ea69..43db81af678c 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -2189,7 +2189,7 @@ static ssize_t feature_config_value_store(struct device *device,
static DEVICE_ATTR_RW(feature_config_value);
-static struct attribute *zynqmp_firmware_attrs[] = {
+static const struct attribute *zynqmp_firmware_attrs[] = {
&dev_attr_ggs0.attr,
&dev_attr_ggs1.attr,
&dev_attr_ggs2.attr,
@@ -2205,7 +2205,18 @@ static struct attribute *zynqmp_firmware_attrs[] = {
NULL,
};
-ATTRIBUTE_GROUPS(zynqmp_firmware);
+static int zynqmp_firmware_pm_sysfs_entry(struct platform_device *pdev)
+{
+ int ret;
+
+ ret = sysfs_create_files(&pdev->dev.kobj, zynqmp_firmware_attrs);
+ if (ret) {
+ pr_err("%s() Failed to create PM firmware attrs, err=%d\n",
+ __func__, ret);
+ }
+
+ return ret;
+}
/**
* zynqmp_clear_pm_state() - Clear subsystem state
@@ -2349,6 +2360,13 @@ static int zynqmp_firmware_probe(struct platform_device *pdev)
return ret;
}
+ ret = zynqmp_firmware_pm_sysfs_entry(pdev);
+ if (ret) {
+ pr_err("%s() Failed to create sysfs file with error%d\n",
+ __func__, ret);
+ return ret;
+ }
+
zynqmp_pm_api_debugfs_init();
if (pm_family_code != PM_ZYNQMP_FAMILY_CODE) {
@@ -2407,7 +2425,6 @@ static struct platform_driver zynqmp_firmware_driver = {
.driver = {
.name = "zynqmp_firmware",
.of_match_table = zynqmp_firmware_of_match,
- .dev_groups = zynqmp_firmware_groups,
},
.probe = zynqmp_firmware_probe,
.remove = zynqmp_firmware_remove,
--
2.43.0