Re: [PATCH net] vsock: only deliver taps to namespaces that can reach the device
From: Bobby Eshleman
Date: Thu Nov 19 2026 - 12:26:25 EST
On Thu, Nov 19, 2026 at 10:03:10AM +0100, Paolo Abeni wrote:
> On 11/17/26 02:20, Bobby Eshleman wrote:
> > On Mon, Nov 16, 2026 at 11:52:38PM +0000, netdev-bot+sinfo@xxxxxxxxxx wrote:
> > > Hi!
> > >
> > > This is an automated message. This series looks like a fix, but its
> > > commit messages seem to be missing some information:
> > >
> > > - How the issue was discovered, e.g. hit in production, hit during
> > > development, syzbot report, manual code inspection, LLM or static
> > > analysis tool scan.
> > >
> > > - Whether the issue was actually triggered, or is only theoretical
> > > (e.g. found by LLM and not proven at runtime). If it was triggered
> > > please include the symptoms, like the stack trace or kernel messages.
> > >
> > > Please do not repost the series just to address the above. Instead,
> > > reply to this email with the missing information, so that reviewers
> > > can take it into account.
> > >
> > > *IMPORTANT*: If you do repost (for other reasons) - please include
> > > the relevant info in the cover letter or commit messages.
> > > --
> > > The evaluation is done by an LLM so it may be wrong, if you think
> > > that is the case please reply and explain.
> >
> > This is a known issue and has come up in review of the guest netns
> > series (so via code inspection).
> My reading of the above is this feels like more an improvement than a
> regression fix. As such I'll move this to net-next. Please scream out
> loudly very soon if you disagree.
>
> /P
>
My net-next guest ns series actually needs this to build, maybe I should
pull it back into that series?
My rationale for sending to net was that it also fixes the issue for the
already merged vhost-vsock ns support. I don't have a strong opinion
either way.
Best,
Bobby