Re: [PATCH] can: softing: lock card->fw.lock unconditionally in softing_card_shutdown()

From: Oliver Hartkopp

Date: Thu Nov 19 2026 - 12:26:48 EST


Hi Ian,

the PCMCIA Softing CANcard2 is discontinued since 2013 and the latest
Windows drivers date back to Windows 7/8.

The Softing CANcard driver is to be removed as there's no known user and we lack the access to this at least 25 y/o hardware for 10 years now:

https://lore.kernel.org/linux-can/20261118092955.1283165-11-mkl@xxxxxxxxxxxxxx/

So thanks for your patch but unfortunately too late.

Btw. beware of Sashiko bot reviews for this obsolete patch that will make you rework the entire driver :-D

Best regards,
Oliver


On 19.11.26 18:07, Ian Rogers wrote:
softing_card_shutdown() calls mutex_lock_interruptible(&card->fw.lock)
with an empty if-body ('{ /* return -ERESTARTSYS */; }'). Because
softing_pdev_remove() invokes softing_card_shutdown() before
unregistering netdevs or removing sysfs attributes, a pending signal
while card->fw.lock is contended causes mutex_lock_interruptible() to
return -EINTR without acquiring the lock. Execution then proceeds unlocked
through IRQ and DPRAM teardown and calls mutex_unlock(&card->fw.lock) on a
mutex not owned by the current task.

Use mutex_lock(&card->fw.lock) in softing_card_shutdown().

Found via an x86_64 LLVM=1 (Clang 21.1.8) allyesconfig audit with
-Wextra-semi-stmt enabled; fix and changelog drafted with an AI coding
assistant. Build-tested under LLVM=1 W=1 (-Werror) and -Wextra-semi-stmt;
not tested on Softing CAN hardware.

Fixes: 03fd3cf5a179 ("can: add driver for Softing card")
Fixes: 47fa0336c1b7 ("can: softing: softing_card_shutdown(): add braces around empty body in an 'if' statement")
Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
---
drivers/net/can/softing/softing_main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/net/can/softing/softing_main.c b/drivers/net/can/softing/softing_main.c
index 519ab3097f86..d3dfad4f5321 100644
--- a/drivers/net/can/softing/softing_main.c
+++ b/drivers/net/can/softing/softing_main.c
@@ -448,9 +448,7 @@ static void softing_card_shutdown(struct softing *card)
{
int fw_up = 0;
- if (mutex_lock_interruptible(&card->fw.lock)) {
- /* return -ERESTARTSYS */;
- }
+ mutex_lock(&card->fw.lock);
fw_up = card->fw.up;
card->fw.up = 0;