Re: [RFC PATCH v4 08/10] nfs: add provenance time (ptime) via FATTR4_TIME_CREATE
From: Amir Goldstein
Date: Thu Nov 19 2026 - 13:07:16 EST
On Sun, Nov 15, 2026 at 7:04 PM koraynilay <koray.fra@xxxxxxxxx> wrote:
>
> Implement provenance time (ptime) in the NFS client, as introduced in a
> previous commit ("vfs: add provenance time (ptime)").
>
> Support reading ptime via statx(2) and file_getattr(), returning the
> cached creation time when the server advertises NFS_ATTR_FATTR_BTIME.
>
> Implement sending FATTR4_TIME_CREATE, asking the server to persist the
> file creation time using ptime on the underlying filesystem.
>
> Also add .fileattr_set to struct nfs_rpc_ops and set it to
> nfs4_fileattr_set() in nfs_v4_clientops. Provide a generic
> nfs_fileattr_set() dispatcher so even symlinks can update ptime under
> NFSv4 while cleanly returning -EOPNOTSUPP on NFSv2/v3.
>
> Assisted-by: Gemini:3.8-flash-high antigravity-cli-1.5.7
> Signed-off-by: koraynilay <koray.fra@xxxxxxxxx>
> ---
> fs/nfs/inode.c | 27 ++++++++++++++++----
> fs/nfs/internal.h | 2 ++
> fs/nfs/nfs4proc.c | 56 ++++++++++++++++++++++++++++++++++++++---
> fs/nfs/nfs4xdr.c | 19 +++++++++-----
> fs/nfs/symlink.c | 1 +
> include/linux/nfs_xdr.h | 3 +++
> 6 files changed, 93 insertions(+), 15 deletions(-)
>
> diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
> index e0a2e92952af..2ddcfd872616 100644
> --- a/fs/nfs/inode.c
> +++ b/fs/nfs/inode.c
> @@ -955,7 +955,7 @@ static u32 nfs_get_valid_attrmask(struct inode *inode)
> reply_mask |= STATX_BLOCKS;
> if (!(cache_validity & NFS_INO_INVALID_BTIME) &&
> (fattr_valid & NFS_ATTR_FATTR_BTIME))
> - reply_mask |= STATX_BTIME;
> + reply_mask |= STATX_BTIME | STATX_PTIME;
> if (!(cache_validity & NFS_INO_INVALID_CHANGE))
> reply_mask |= STATX_CHANGE_COOKIE;
> return reply_mask;
> @@ -978,10 +978,10 @@ int nfs_getattr(const struct mnt_idmap *idmap, const struct path *path,
> request_mask &= STATX_TYPE | STATX_MODE | STATX_NLINK | STATX_UID |
> STATX_GID | STATX_ATIME | STATX_MTIME | STATX_CTIME |
> STATX_INO | STATX_SIZE | STATX_BLOCKS | STATX_BTIME |
> - STATX_CHANGE_COOKIE;
> + STATX_PTIME | STATX_CHANGE_COOKIE;
>
> if (!(fattr_valid & NFS_ATTR_FATTR_BTIME))
> - request_mask &= ~STATX_BTIME;
> + request_mask &= ~(STATX_BTIME | STATX_PTIME);
>
> if ((query_flags & AT_STATX_DONT_SYNC) && !force_sync) {
> if (readdirplus_enabled)
> @@ -1015,7 +1015,7 @@ int nfs_getattr(const struct mnt_idmap *idmap, const struct path *path,
> if (!(request_mask & (STATX_MODE|STATX_NLINK|STATX_ATIME|STATX_CTIME|
> STATX_MTIME|STATX_UID|STATX_GID|
> STATX_SIZE|STATX_BLOCKS|STATX_BTIME|
> - STATX_CHANGE_COOKIE)))
> + STATX_PTIME|STATX_CHANGE_COOKIE)))
> goto out_no_revalidate;
>
> /* Check whether the cached attributes are stale */
> @@ -1038,7 +1038,7 @@ int nfs_getattr(const struct mnt_idmap *idmap, const struct path *path,
> do_update |= cache_validity & NFS_INO_INVALID_OTHER;
> if (request_mask & STATX_BLOCKS)
> do_update |= cache_validity & NFS_INO_INVALID_BLOCKS;
> - if (request_mask & STATX_BTIME)
> + if (request_mask & (STATX_BTIME | STATX_PTIME))
> do_update |= cache_validity & NFS_INO_INVALID_BTIME;
>
> if (do_update) {
> @@ -1061,6 +1061,7 @@ int nfs_getattr(const struct mnt_idmap *idmap, const struct path *path,
> if (S_ISDIR(inode->i_mode))
> stat->blksize = NFS_SERVER(inode)->dtsize;
> stat->btime = NFS_I(inode)->btime;
> + stat->ptime = NFS_I(inode)->btime;
>
As an example of what would be needed per the mutable btime proposal,
adding stat->ptime and STATX_PTIME will not be needed...
> /* Special handling for STATX_DIOALIGN and STATX_DIO_READ_ALIGN
> * - NFS doesn't have DIO alignment constraints, avoid getting
> @@ -1092,10 +1093,26 @@ int nfs_fileattr_get(struct dentry *dentry, struct file_kattr *fa)
> }
> if (nfs_server_capable(inode, NFS_CAP_CASE_NONPRESERVING))
> fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
This would need:
fa->fsx_xflags |= FS_XFLAG_CASEFOLD;
+ fa->fsx_xflags_mask |= FS_XFLAG_CASEFOLD;
+ fa->fsx_xflags_ro_mask |= FS_XFLAG_CASEFOLD;
+ /* unlink other fs FS_CASEFOLD_FL is read-only */
fa->flags |= FS_CASEFOLD_FL;
}
fa->fsx_xflags |= FS_XFLAG_CASENONPRESERVING;
+ fa->fsx_xflags_mask |= FS_XFLAG_CASENONPRESERVING;
+ fa->fsx_xflags_ro_mask |= FS_XFLAG_CASENONPRESERVING;
> + if (NFS_SERVER(inode)->fattr_valid & NFS_ATTR_FATTR_BTIME) {
> + fa->fsx_xflags |= FS_XFLAG_PTIME;
> + fa->fsx_xflags_mask |= FS_XFLAG_PTIME;
> + fa->fsx_ptime = NFS_I(inode)->btime;
> + }
+ fa->fsx_xflags |= FS_XFLAG_BTIME;
+ fa->fsx_xflags_mask |= FS_XFLAG_BTIME;
+ fa->fsx_btime = NFS_I(inode)->btime;
Fs with immutable btime could either not advertise the BTIME flag
in xflags/xflags_mask or advertise the flag also in xflags_ro_mask.
> return 0;
> }
> EXPORT_SYMBOL_GPL(nfs_fileattr_get);
>
> +int nfs_fileattr_set(const struct mnt_idmap *idmap, struct dentry *dentry,
> + struct file_kattr *fa)
> +{
> + const struct nfs_rpc_ops *ops = NFS_PROTO(d_inode(dentry));
> +
> + if (ops->fileattr_set)
> + return ops->fileattr_set(idmap, dentry, fa);
> + return -EOPNOTSUPP;
> +}
> +EXPORT_SYMBOL_GPL(nfs_fileattr_set);
> +
> static void nfs_init_lock_context(struct nfs_lock_context *l_ctx)
> {
> refcount_set(&l_ctx->count, 1);
> diff --git a/fs/nfs/internal.h b/fs/nfs/internal.h
> index 5af6a032f145..0e47fad944de 100644
> --- a/fs/nfs/internal.h
> +++ b/fs/nfs/internal.h
> @@ -458,6 +458,8 @@ extern int nfs_wait_bit_killable(struct wait_bit_key *key, int mode);
>
> struct file_kattr;
> int nfs_fileattr_get(struct dentry *dentry, struct file_kattr *fa);
> +int nfs_fileattr_set(const struct mnt_idmap *idmap, struct dentry *dentry,
> + struct file_kattr *fa);
>
> #if IS_ENABLED(CONFIG_NFS_LOCALIO)
> /* localio.c */
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index e1018b03c1cb..31d58ceb4dc0 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -55,6 +55,7 @@
> #include <linux/utsname.h>
> #include <linux/freezer.h>
> #include <linux/iversion.h>
> +#include <linux/fileattr.h>
>
> #include "nfs4_fs.h"
> #include "delegation.h"
> @@ -98,7 +99,8 @@ static int _nfs4_proc_getattr(struct nfs_server *server, struct nfs_fh *fhandle,
> struct nfs_fattr *fattr, struct inode *inode);
> static int nfs4_do_setattr(struct inode *inode, const struct cred *cred,
> struct nfs_fattr *fattr, struct iattr *sattr,
> - struct nfs_open_context *ctx, struct nfs4_label *ilabel);
> + struct nfs_open_context *ctx, struct nfs4_label *ilabel,
> + const struct timespec64 *time_create);
> static struct rpc_task *_nfs41_proc_sequence(struct nfs_client *clp,
> const struct cred *cred,
> struct nfs4_slot *slot,
> @@ -3216,7 +3218,7 @@ static int _nfs4_do_open(struct inode *dir,
> nfs_fattr_init(opendata->o_res.f_attr);
> status = nfs4_do_setattr(state->inode, cred,
> opendata->o_res.f_attr, sattr,
> - ctx, label);
> + ctx, label, NULL);
> if (status == 0) {
> nfs_setattr_update_inode(state->inode, sattr,
> opendata->o_res.f_attr);
> @@ -3380,7 +3382,8 @@ static int _nfs4_do_setattr(struct inode *inode,
>
> static int nfs4_do_setattr(struct inode *inode, const struct cred *cred,
> struct nfs_fattr *fattr, struct iattr *sattr,
> - struct nfs_open_context *ctx, struct nfs4_label *ilabel)
> + struct nfs_open_context *ctx, struct nfs4_label *ilabel,
> + const struct timespec64 *time_create)
> {
> struct nfs_server *server = NFS_SERVER(inode);
> __u32 bitmask[NFS4_BITMASK_SZ];
> @@ -3391,6 +3394,7 @@ static int nfs4_do_setattr(struct inode *inode, const struct cred *cred,
> .server = server,
> .bitmask = bitmask,
> .label = ilabel,
> + .time_create = time_create,
> };
> struct nfs_setattrres res = {
> .fattr = fattr,
> @@ -3414,6 +3418,9 @@ static int nfs4_do_setattr(struct inode *inode, const struct cred *cred,
> if (sattr->ia_valid & ATTR_MTIME)
> adjust_flags |= NFS_INO_INVALID_MTIME;
>
> + if (time_create)
> + adjust_flags |= NFS_INO_INVALID_BTIME;
> +
> do {
> nfs4_bitmap_copy_adjust(bitmask, nfs4_bitmask(server, fattr->label),
> inode, adjust_flags);
> @@ -4587,7 +4594,7 @@ nfs4_proc_setattr(struct dentry *dentry, struct nfs_fattr *fattr,
> if ((sattr->ia_valid & (ATTR_MODE|ATTR_UID|ATTR_GID)) != 0)
> nfs4_inode_make_writeable(inode);
>
> - status = nfs4_do_setattr(inode, cred, fattr, sattr, ctx, NULL);
> + status = nfs4_do_setattr(inode, cred, fattr, sattr, ctx, NULL, NULL);
> if (status == 0) {
> nfs_setattr_update_inode(inode, sattr, fattr);
> nfs_setsecurity(inode, fattr);
> @@ -10845,6 +10852,44 @@ static void nfs4_disable_swap(struct inode *inode)
> wake_up_var(&clp->cl_state);
> }
>
> +#define NFS4_SUPPORTED_XFLAGS (FS_XFLAG_PTIME)
> +static int nfs4_fileattr_set(const struct mnt_idmap *idmap, struct dentry *dentry,
> + struct file_kattr *fa)
> +{
> + struct inode *inode = d_inode(dentry);
> + struct nfs_server *server = NFS_SERVER(inode);
> + struct nfs_fattr *fattr;
> + struct iattr sattr = { .ia_valid = 0 };
> + const struct timespec64 *time_create = NULL;
> + int error;
> +
> + if (!(server->fattr_valid & NFS_ATTR_FATTR_BTIME))
> + return -EOPNOTSUPP;
> +
> + if (fa->flags_valid)
> + return -EOPNOTSUPP;
> +
> + if (fileattr_has_fsx_mask(fa, NFS4_SUPPORTED_XFLAGS))
> + return -EOPNOTSUPP;
> +
> + if (fa->fsx_xflags_mask & ~NFS4_SUPPORTED_XFLAGS)
> + return -EOPNOTSUPP;
> +
These two checks look semantically identical.
I am not sure yet what you intention was with the
fileattr_has_fsx_mask() helper - I know you had reservations about it
but at least in this code, it doesn't look like it is needed at all.
> + if (fa->fsx_xflags_mask & FS_XFLAG_PTIME)
> + time_create = &fa->fsx_ptime;
This would be BTIME/btime but otherwise the same.
Thanks,
Amir.