Re: [PATCH v3] ftrace: Reject "!!" in front of a set_ftrace_filter command
From: Masami Hiramatsu (Google)
Date: Thu Nov 19 2026 - 19:22:24 EST
On Thu, 19 Nov 2026 11:12:05 -0800, Yifan Feng <evanfengff@xxxxxxxxx> wrote:
> A command written to set_ftrace_filter with two '!' in front of the
> function glob triggers the WARN_ON() in
> unregister_ftrace_function_probe_func():
>
> # echo '!!vfs_read:traceoff' >> set_ftrace_filter
> WARNING: kernel/trace/ftrace.c:5675 at unregister_ftrace_function_probe_func+0x662/0x870
>
> The command callbacks strip the first '!' and pass the rest as the glob
> of the probe to remove. filter_parse_regex() then reports the second
> '!' as a negated glob, which function probes do not support.
>
> Return -EINVAL for such input in ftrace_process_regex(), before a
> command callback is called.
>
> Fixes: 23b4ff3aa479 ("ftrace: add traceon traceoff commands to enable/disable the buffers")
> Suggested-by: Steven Rostedt <rostedt@xxxxxxxxxxx>
> Signed-off-by: Yifan Feng <evanfengff@xxxxxxxxx>
Looks good to me.
Reviewed-by: Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>
Thanks,
> ---
> v3: add the comment above the check that Steven Rostedt asked for. No code change.
> v2: https://lore.kernel.org/linux-trace-kernel/20261119030900.37343-1-evanfengff@xxxxxxxxx
> QEMU with the v2 code, all 7 probe commands: one WARNING each before, none after.
> Found and written with the help of an AI coding assistant.
>
> kernel/trace/ftrace.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index c7d74b33d36d..4e4337243797 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -5846,6 +5846,13 @@ static int ftrace_process_regex(struct ftrace_iterator *iter,
>
> /* command found */
>
> + /*
> + * A double "!!" confuses the parser. This isn't a boolean operation,
> + * simply reject it.
> + */
> + if (func[0] == '!' && func[1] == '!')
> + return -EINVAL;
> +
> command = strsep(&next, ":");
>
> guard(mutex)(&ftrace_cmd_mutex);
>
> base-commit: 4405c18c95d2d0f99f6c581ef0ee8591a1aa6ccd
> --
> 2.39.3 (Apple Git-146)
>
>
--
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx>