[PATCH] MIPS: Ingenic: Allow assembler reordering in the XBurst secondary entry
From: Florian Fainelli
Date: Fri Nov 20 2026 - 00:08:54 EST
Remove .set noreorder and the two explicit delay-slot nops from the
XBurst secondary CPU reset entry. GNU as emits identical reset-entry
instructions with reordering enabled in both the CI20 and generic
MIPS64r2 Ingenic SMP builds.
On CI20, two baseline and three updated cold boots brought both CPUs
online. Each boot passed the CPU affinity check and 100 cross-core
idle-wakeup round trips in each direction. Codex assisted with the
assembly comparison and hardware test campaign.
Suggested-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>
Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
---
Thomas, feel free to fixup into "MIPS: Ingenic: Add XBurst SMP support"
if that is simpler. Thanks!
arch/mips/ingenic/ingenic-smp-entry.S | 3 ---
1 file changed, 3 deletions(-)
diff --git a/arch/mips/ingenic/ingenic-smp-entry.S b/arch/mips/ingenic/ingenic-smp-entry.S
index 290e23c65707..d6aa4b4b1a17 100644
--- a/arch/mips/ingenic/ingenic-smp-entry.S
+++ b/arch/mips/ingenic/ingenic-smp-entry.S
@@ -16,7 +16,6 @@
/* The CP0 REIM register only stores the upper 16 address bits. */
.section .text.smp-entry, "ax"
.balign 0x10000
- .set noreorder
LEAF(xburst_secondary_cpu_entry)
mtc0 zero, CP0_CAUSE
li t0, ST0_CU0
@@ -32,7 +31,6 @@ LEAF(xburst_secondary_cpu_entry)
cache Index_Store_Tag_D, 0(t0)
addiu t0, t0, CACHE_LINESIZE
bne t0, t1, 1b
- nop
mfc0 t0, CP0_CONFIG
li t1, ~CONF_CM_CMASK
@@ -50,5 +48,4 @@ LEAF(xburst_secondary_cpu_entry)
PTR_LA t0, smp_bootstrap
jr t0
- nop
END(xburst_secondary_cpu_entry)
--
2.53.0