Re: [PATCH] MIPS: Ingenic: Allow assembler reordering in the XBurst secondary entry

From: Maciej W. Rozycki

Date: Fri Nov 20 2026 - 09:07:11 EST


On Thu, 19 Nov 2026, Florian Fainelli wrote:

> Remove .set noreorder and the two explicit delay-slot nops from the
> XBurst secondary CPU reset entry. GNU as emits identical reset-entry
> instructions with reordering enabled in both the CI20 and generic
> MIPS64r2 Ingenic SMP builds.
>
> On CI20, two baseline and three updated cold boots brought both CPUs
> online. Each boot passed the CPU affinity check and 100 cross-core
> idle-wakeup round trips in each direction. Codex assisted with the
> assembly comparison and hardware test campaign.
>
> Suggested-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
> ---
> Thomas, feel free to fixup into "MIPS: Ingenic: Add XBurst SMP support"
> if that is simpler. Thanks!

Have you compared objects produced to be the same with and without the
change applied? If they are, then:

Reviewed-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>

Thanks for this follow-up cleanup.

Maciej